-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic praise function #1
Comments
Sounds good! We could also import your package building package and have praise_build() which simply calls that with a piece of praise if it succeeds. |
I guess I will import |
Ahh, that'd make more sense! |
I think it would be good to break the word list down in to parts of speech so you could have "You're a {adverb} programmer" or "{Adjective} work!". (and matching capitalisation would also be handy) |
@hadley yes, that makes sense. I would even classify them further. "{Adjective} work!" often makes less sense than "{Positive adjective} work!". Matching capitalization is also a good idea. |
I just assumed all the adjectives would be positive in this package ;) |
Yeah, right. :) |
* Update adverb.R Closes #1 * Added clever to adjectives
* Add "ooh" to exclamation.R closes #1 * Add smiley
* Added rockandrool Added rockandroll, closes #1. * adjective ordering fix (rockandroll was misplaced) closes 2
So I thought for starters we could have something like:
and then
praise
just inserts a random adjective fromsuperb
into the template.?
The text was updated successfully, but these errors were encountered: