Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic praise function #1

Closed
gaborcsardi opened this issue Jul 30, 2015 · 7 comments · Fixed by #17 or #31
Closed

Basic praise function #1

gaborcsardi opened this issue Jul 30, 2015 · 7 comments · Fixed by #17 or #31

Comments

@gaborcsardi
Copy link
Collaborator

So I thought for starters we could have something like:

praise <- function(template = "This is ${superb}!") {
  ## ...
}

and then praise just inserts a random adjective from superb into the template.

?

@Ironholds
Copy link

Sounds good! We could also import your package building package and have praise_build() which simply calls that with a piece of praise if it succeeds.

@gaborcsardi
Copy link
Collaborator Author

I guess I will import praise in mason, or maybe that's what you meant. I think praise could be pretty generic, the madlibs engine if you like.

@Ironholds
Copy link

Ahh, that'd make more sense!

@hadley
Copy link

hadley commented Jul 30, 2015

I think it would be good to break the word list down in to parts of speech so you could have "You're a {adverb} programmer" or "{Adjective} work!". (and matching capitalisation would also be handy)

@gaborcsardi
Copy link
Collaborator Author

@hadley yes, that makes sense. I would even classify them further. "{Adjective} work!" often makes less sense than "{Positive adjective} work!".

Matching capitalization is also a good idea.

@hadley
Copy link

hadley commented Jul 30, 2015

I just assumed all the adjectives would be positive in this package ;)

@gaborcsardi
Copy link
Collaborator Author

Yeah, right. :)

gaborcsardi pushed a commit that referenced this issue Apr 5, 2016
gaborcsardi pushed a commit that referenced this issue Apr 5, 2016
* Update adverb.R

Closes #1

* Added clever to adjectives
gaborcsardi pushed a commit that referenced this issue Apr 6, 2016
Added a verb "done"
gaborcsardi pushed a commit that referenced this issue Apr 6, 2016
Added the word 'metal'.
gaborcsardi pushed a commit that referenced this issue Apr 6, 2016
* Add "ooh" to exclamation.R closes #1

* Add smiley
gaborcsardi pushed a commit that referenced this issue Apr 6, 2016
This should close issue number 1
gaborcsardi pushed a commit that referenced this issue Apr 6, 2016
gaborcsardi pushed a commit that referenced this issue Apr 7, 2016
* Added rockandrool

Added rockandroll, closes #1.

* adjective ordering fix (rockandroll was misplaced)

closes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants