update #8
Merged
update #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Auspice should work on a wide range of nodejs versions. Here I specified between 10.8 and 13.14 as they are the versions I've personally run auspice on without trouble.
Relax requirement for nodejs 10.8. Closes #1161.
This fixes a bug where a narrative slide-change requests that the tree both zoom and change color. This was introduced by 0639da8 which, as part of the (now disabled) push for SVG gradient rendering of branches, moved the d3 call to update the stroke (branch color) into a separate code block, in order that it can behave differently for "T" and "S" parts of a branch. This code-block is not run when the tree zooms (that is the bug). Here we partially revert that commit. This should be revisited when we re-enable SVG gradients.
[bugfix] allow narratives to simultaneously zoom and change color
This commit signifies a shift to storing a set of narrative files in this repo, as opposed to obtaining the nextstrain.org narratives via a script. The Nextstrain.org narratives are still obtainable (they are all stored in their own github repo) and the docs have been updated to show this. By storing and maintaining "test narratives" in the auspice repo we can both provide examples of the capability of narratives and use them to test functionality and fix bugs. As the are stored in the `narratives` directory, they are available via Nextstrain Community URLs at nextstrain.org/community/narratives/nextstrain/auspice/...
This builds on our previous efforts to develop snapshot testing (not being run automatically at the moment). Here we dynamically compare snapshots for each page within a test-narrative. This code may be refactored so that we can easily test a wide range of narratives in this fashion. Changes to the content of the narrative, including the addition of slides, should cause this test to fail, however the screenshots can be regenerated (see DEV_DOCS) without the need to modify the test script itself.
add url query for transmission
Implement screenshot testing for narratives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.