Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through DXF import options for better geometry creation #274

Closed
wants to merge 4 commits into from

Conversation

ccaprani
Copy link
Contributor

@ccaprani ccaprani commented May 5, 2023

For curves and other complex geometries, the default options in cad2shapely may not suffice. This PR exposes the optional inputs to the sectionproperties user in from_dxf.

A few minor tweaks to the documentation for correctness, and black autoformatting removed a few parentheses.

@ccaprani
Copy link
Contributor Author

ccaprani commented May 5, 2023

The Lint checks are failing on files I haven't edited ;-)

would reformat /home/runner/work/section-properties/section-properties/examples/01-advanced/05_trapz_approximation.py
would reformat /home/runner/work/section-properties/section-properties/sectionproperties/analysis/fea.py
would reformat /home/runner/work/section-properties/section-properties/sectionproperties/pre/library/steel_sections.py 
would reformat /home/runner/work/section-properties/section-properties/sectionproperties/pre/pre.py 
would reformat /home/runner/work/section-properties/section-properties/sectionproperties/analysis/section.py 
would reformat /home/runner/work/section-properties/section-properties/sectionproperties/tests/test_concrete_sections.py

@robbievanleeuwen robbievanleeuwen changed the base branch from master to hypermodern June 11, 2023 12:30
@robbievanleeuwen robbievanleeuwen self-requested a review June 11, 2023 12:30
@robbievanleeuwen robbievanleeuwen self-assigned this Jun 11, 2023
@robbievanleeuwen robbievanleeuwen added enhancement New feature or request documentation Improvements or additions to documentation labels Jun 11, 2023
@robbievanleeuwen
Copy link
Owner

robbievanleeuwen commented Jun 11, 2023

Thanks @ccaprani, this looks good!

I'm going to look to merge this into the hypermodern branch so that it can be better integrated into the upcoming v3.0 release. Once I finish the updated docs I'll resolve the conflicts :)

@robbievanleeuwen robbievanleeuwen mentioned this pull request Jun 11, 2023
@robbievanleeuwen
Copy link
Owner

Moved to #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants