Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1649 more rule editing prep #212

Merged
merged 6 commits into from
Dec 5, 2024
Merged

feature/mx-1649 more rule editing prep #212

merged 6 commits into from
Dec 5, 2024

Conversation

cutoffthetop
Copy link
Contributor

@cutoffthetop cutoffthetop commented Dec 4, 2024 •
edited
Loading

PR Context

Changes

  • harmonize error handling for transforming raw rule-sets to responses
  • return 404 on GET rule-set endpoint, when no rules are found

Removed

  • removed not needed mex.backend.constants module

rababerladuseladim
rababerladuseladim previously approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@rababerladuseladim rababerladuseladim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean, only one idea. Feel free to merge if you don't like the idea.

mex/backend/rules/helpers.py Show resolved Hide resolved
@cutoffthetop cutoffthetop merged commit 5880fcc into main Dec 5, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1649-more-rule-editing-prep branch December 5, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rababerladuseladim rababerladuseladim rababerladuseladim left review comments

Assignees

@cutoffthetop cutoffthetop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cutoffthetop @rababerladuseladim