feature/mx-1649 prevent and subtract #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
…itor into feature/mx-1702-resolve-types
# PR Context - needs robert-koch-institut/mex-common#207 # Added <!-- New features and interfaces --> # Changes - updated the model config for preview of search results for model v3 # Deprecated <!-- Soon-to-be removed features --> # Removed <!-- Definitely removed features --> # Fixed <!-- Fixed bugs --> # Security <!-- Fixed vulnerabilities --> Co-authored-by: Franziska Diehr <DiehrF@rki.de>
…bert-koch-institut/mex-editor into feature/mx-1702-resolve-types
cutoffthetop
changed the base branch from
main
to
feature/mx-1702-resolve-types
…itor into feature/mx-1649-prevent-and-subtract
cutoffthetop
added a commit
to robert-koch-institut/mex-backend
that referenced
this pull request
Nov 18, 2024
# PR Context - prep for robert-koch-institut/mex-editor#192 # Changes - improve error handling by returning validation issues for InconsistentGraphErrors - pin mex-release to 0.3.0 --------- Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
…itor into feature/mx-1649-prevent-and-subtract
cutoffthetop
added a commit
to robert-koch-institut/mex-common
that referenced
this pull request
Nov 29, 2024
### PR Context - some fixes and additions for robert-koch-institut/mex-editor#192 - `mex/common/fields.py` is a port of [`mex/backend/fields.py`](https://github.com/robert-koch-institut/mex-backend/blob/0.22.0/mex/backend/fields.py) - because it is needed by the editor too - prevent pydantic 2.10, because it broke tests: #341 ### Added - add vocabulary and temporal unions and lookups to `mex.common.types` - add `mex.common.fields` with field type by class name lookups ### Changes - set default empty rules to all of the rule-set models - pin pydantic to sub 2.10 (for now) because of breaking changes ### Fixed - switch HTTP method for preview endpoint to `POST` - add optional values to variadic values for distribution models - make `endpointDescription` optional for variadic access platform models --------- Signed-off-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
cutoffthetop
added a commit
to robert-koch-institut/mex-backend
that referenced
this pull request
Dec 5, 2024
### PR Context - prep for robert-koch-institut/mex-editor#192 ### Changes - harmonize error handling for transforming raw rule-sets to responses - return 404 on GET rule-set endpoint, when no rules are found ### Removed - removed not needed `mex.backend.constants` module
cutoffthetop
added a commit
to robert-koch-institut/mex-common
that referenced
this pull request
Dec 10, 2024
### PR Context - prep for robert-koch-institut/mex-editor#192 - preview models don't care about required fields and length limits for lists - they will be used by the editor to be able to search even for potentially "broken" items - also includes some clean-up of the `mex.common.models` module (imports, exports and docs) ### Added - add preview models for merged items without cardinality validation - BREAKING: preview models are now part of all `mex.common.fields` lookups - add `BackendApiConnector.fetch_preview_items` for fetching previews ### Deprecated - stop using `ExtractedData`, use `AnyExtractedModel` instead - stop using `MergedItem`, use `AnyMergedModel` instead - stop using `AdditiveRule`, use `AnyAdditiveRule` instead - stop using `SubtractiveRule`, use `AnySubtractiveRule` instead - stop using `PreventiveRule`, use `AnyPreventiveRule` instead - stop using `BaseEntity`, use a concrete union instead ### Removed - removed deprecated `BulkInsertResponse` as alias for `IdentifiersResponse` - removed unused module export of `mex.common.models.generate_entity_filter_schema` - removed unused module export of `mex.common.models.generate_mapping_schema` - drop export `models.ExtractedPrimarySourceIdentifier`, import from `types` instead - drop export `models.MergedPrimarySourceIdentifier`, import from `types` instead
cutoffthetop
added a commit
to robert-koch-institut/mex-backend
that referenced
this pull request
Dec 10, 2024
# PR Context - needs robert-koch-institut/mex-common#347 - prep for robert-koch-institut/mex-editor#192 # Added - allow item merging functions to ignore cardinality and output preview items # Changes - create new endpoint for fetching previews of merged items - replaced `mex.backend.fields` with `mex.common` counterpart # Removed - removed over-engineered `reraising` function
…itor into feature/mx-1649-prevent-and-subtract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
Added
Changes
Deprecated
Removed
Fixed
Security