Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Webpack Plugin to be compatible with Webpack 4 (fixes #47) #48

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Updated Webpack Plugin to be compatible with Webpack 4 (fixes #47) #48

merged 2 commits into from
Nov 16, 2018

Conversation

spiltcoffee
Copy link

No description provided.

@spiltcoffee spiltcoffee mentioned this pull request Nov 14, 2018
@robertknight
Copy link
Owner

Can you confirm if this change is backwards compatible with older versions of webpack and if so, how far back it is compatible? If it works with webpack v4+ only then we could still merge this but should also bump the major version of the package and make a note in the changelog.

@spiltcoffee
Copy link
Author

My understanding is that this was a breaking change in Webpack 4, so I assume this change would break the plugin for all versions less than Webpack 4.

It might be possible to supply backwards compatibility according to this, but it requires additional work (and testing) on top of this pull request.

@robertknight
Copy link
Owner

OK, in that case I can merge this as is but will bump the package version to 3.0.0 and make a note in the changelog that the plugin requires Webpack 4.x+. Anyone who is using an older version of Webpack can use an earlier 2.x release.

@robertknight robertknight merged commit 8a52b4f into robertknight:master Nov 16, 2018
@robertknight
Copy link
Owner

Published as v3.0.0.

@spiltcoffee spiltcoffee deleted the Webpack4 branch November 21, 2018 06:18
@spiltcoffee
Copy link
Author

So I know this is pulled in now and v3.0.0 is out there now, but I just stumbled across this pull request: vuejs/vue#7839

The changes in that pull request to util.js show how you could possibly go about providing backwards compatibility if that's something that you still desire.

@robertknight
Copy link
Owner

Thanks for following up on that question. I'll wait until someone asks for it 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants