-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redesigned annotators #170
Conversation
@hardikdava I created a feature branch that we can use to redesign annotators and make them more modular according to our discussion here #168 I decided that we will conduct all work around annotators on this feature branch and when we are done we will merge this branch as a whole into |
Hi @SkalskiP 👋 , cool!. I will add |
Test script to test new annotators.
|
@SkalskiP I made progress on this feature. |
Hi @SkalskiP 👋 I am planning to keep continue contribute to
|
@hardikdava, how about meeting for 30 minutes on video call and talking through the priorities? In principle, I would like us to be focused on those tasks in the first place: #181, but with all the loose ends I think meeting is the right move. |
@SkalskiP Of course, we can talk. Let me know when we can have a short call. |
@hardikdava zoom or google meet? |
@SkalskiP Google meet is fine. |
@hardikdava you are based in Germany? Can we meet at 8 PM? Or you'd like to do it earlier? |
@SkalskiP Yeah, I am based in Germany. Would it possible to talk at 6 PM? |
@hardikdava, not today, but I could meet at 6 PM tomorrow. How about that? |
@SkalskiP let's talk at 8 PM today then. I can make it. |
@SkalskiP On side note, I am adding |
…nto feature/redesigned_annotators
…nto feature/redesigned_annotators
…nto feature/redesigned_annotators
…nto feature/redesigned_annotators
…nto feature/redesigned_annotators
@onuralpszr sure you can merge it in once I'm ready. I'm still not done, but tests are looking good. You can take a look here: https://colab.research.google.com/drive/1iso4sYNNERe6KqH6zUixF7XwsapbCgzZ?usp=sharing |
…nto feature/redesigned_annotators
@hardikdava and @onuralpszr take a look at the PR 🙏🏻 I dropped a few things from PR. We will add them to the next PRs. Still, we are getting most of the functionalities here. I tested the changes here: https://colab.research.google.com/drive/1iso4sYNNERe6KqH6zUixF7XwsapbCgzZ?usp=sharing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me.
I am still looking and adding something will post soon |
@onuralpszr let me know when you are ready ;) |
…on adjusted Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
c137cc0
to
07c344e
Compare
@onuralpszr, are we ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hardikdava @SkalskiP thank you both for your awesome work. I am merging into develop let's continue make supervision even better.
@onuralpszr I'm going to promote that feature hard this and next week! |
This PR expands our range of Annotators and makes them more reusable.