Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cornered box annotator #171

Merged
merged 19 commits into from
Jul 23, 2023
Merged

cornered box annotator #171

merged 19 commits into from
Jul 23, 2023

Conversation

hardikdava
Copy link
Collaborator

Description

As discussed in #168 and #170 . Merging new annotation format for initial commit.

@SkalskiP it might needed to refine a bit.

Type of change

  • New feature (non-breaking change which adds functionality)

@hardikdava hardikdava mentioned this pull request Jul 3, 2023
Merged
@hardikdava
Copy link
Collaborator Author

@SkalskiP Please merge this branch before further work. I already finished some implementation.

@hardikdava
Copy link
Collaborator Author

@SkalskiP #49 is also included in this PR.

@SkalskiP SkalskiP added the version: 0.12.0 Feature to be added in `0.12.0` release label Jul 4, 2023
@hardikdava
Copy link
Collaborator Author

@SkalskiP This feature is ready for review. It includes #49 #159 #168 features.

@hardikdava
Copy link
Collaborator Author

@SkalskiP I changed code style to consistent style as Annotators.annotate(scene, detection) format. Please review it and merge the PR.

@hardikdava
Copy link
Collaborator Author

hardikdava commented Jul 7, 2023 •
edited
Loading

@SkalskiP EllipseAnotator is also added to the Annotators API. #16

@hardikdava hardikdava mentioned this pull request Jul 17, 2023
Closed
1 task
@SkalskiP SkalskiP added this to the version: 0.12.0 milestone Jul 18, 2023
SkalskiP
SkalskiP requested changes Jul 18, 2023
View reviewed changes
@SkalskiP
Copy link
Collaborator

@hardikdava I left you few comments already. I'm taking a look at the rest of the code, as well as testing it. But there are a few things that I need to think about tomorrow. Please start implementing the changes I already listed. 🙏🏻

SkalskiP
SkalskiP requested changes Jul 20, 2023
View reviewed changes
@hardikdava
Copy link
Collaborator Author

@SkalskiP I have added tests for get_anchor_coordinates

@SkalskiP SkalskiP merged commit 1d28b8a into roboflow:feature/redesigned_annotators Jul 23, 2023
@hardikdava hardikdava deleted the advanced_box_annotator branch August 10, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkalskiP SkalskiP SkalskiP requested changes

Assignees

@hardikdava hardikdava

Labels
version: 0.12.0 Feature to be added in `0.12.0` release
Projects
Supervision Board
Archived in project
Milestone
version: 0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hardikdava @SkalskiP