Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Extend LaunchManager for Environments #216

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

tunahanertekin
Copy link
Contributor

🌿 PR: Extend LaunchManager for Environments

Description

LaunchManagers can be used in Environments in cmd mode.

Closes #214

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How can it be tested?

Can be tested by a sample LaunchManager:

apiVersion: robot.roboscale.io/v1alpha1
kind: LaunchManager
metadata:
  name: lm-test
  namespace: test
  labels:
    robolaunch.io/target-robot: test
    robolaunch.io/target-vdi: abc
spec:
  launches:
    something:
      container:
        display: false
        env:
        - name: TEST_ENV
          value: testing
        privileged: false
      entrypoint:
        cmd: |-
          pwd && ls -la && sleep infinity
        disableSourcingWs: true
        type: Custom
      instances:
      - org-development-45679050
      namespacing: false
      scope:
        scopeType: Path
        workspace: /home/robolaunch

@tunahanertekin tunahanertekin added the enhancement New feature or request label Jan 19, 2024
@tunahanertekin tunahanertekin self-assigned this Jan 19, 2024
@tunahanertekin tunahanertekin linked an issue Jan 19, 2024 that may be closed by this pull request
@tunahanertekin tunahanertekin merged commit 96332bf into main Jan 19, 2024
1 check passed
@tunahanertekin tunahanertekin deleted the 214-refactoring-launchmanager branch January 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Manager CRDs
1 participant