Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gz-sim-yarp-plugins-check-model test on apt CI #191

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

xela-95
Copy link
Member

@xela-95 xela-95 commented Aug 14, 2024

This PR enables the gz-sim-yarp-plugins-check-model test introduced in #179 and excluded from apt CI for an issue solved in #185.

@xela-95 xela-95 self-assigned this Aug 14, 2024
@xela-95
Copy link
Member Author

xela-95 commented Aug 14, 2024

Now it seems that this test is now passing also on apt.

@xela-95 xela-95 requested a review from traversaro August 14, 2024 09:08
@traversaro
Copy link
Member

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in #186 .

@xela-95
Copy link
Member Author

xela-95 commented Aug 14, 2024

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in #186 .

do you mean to remove the --repeat until-pass arguments in test for both apt CI and conda CI?

@traversaro
Copy link
Member

traversaro commented Aug 14, 2024

I suspect we could try (even in another PR) also to reduce the --repeat until-pass: settings, as many flaky failure I think could be due to the race condition fixed in #186 .

do you mean to remove the --repeat until-pass arguments in test for both apt CI and conda CI?

It is something that we could try, but it is independent from this PR.

@xela-95
Copy link
Member Author

xela-95 commented Aug 14, 2024

Merging! 🚀

@xela-95 xela-95 merged commit 7a750e0 into main Aug 14, 2024
5 checks passed
@xela-95 xela-95 deleted the ci/enable-check-model-test branch August 14, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants