Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthCalibrator: fixed CheckHwFault #866

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

valegagge
Copy link
Member

During the investigation of this ticket, @MSECode and I noticed some bugs in the Ethernet calibrator.

  1. there is an empty debug string: DEBUG] Left_Arm_Calibrator : Joints calibration order:
  2. the checkHWFault function performed a loop on the joints in (0, totJointsToCalibrate) range instead of on the list containing the required joints.
  3. the return value of checkHWFault function was ignored.

We fixed them in this way:
1.
Screenshot from 2023-04-27 12-03-54

  1. the loop in performed on the elements containing in the list of joints to calibrate
Before After
Screenshot from 2023-04-27 12-06-07 Screenshot from 2023-04-27 12-06-50
  1. Added a check on the return value of checkHWFault function
    Screenshot from 2023-04-27 12-09-23

Results:

Here there are the logs of the left arm during calibration where the joint number 9 is omitted

Before

[DEBUG] left_arm-calibrator starting calibration of device left_arm-mc_remapper
[INFO] Left_Arm_Calibrator : starting calibration
[ERROR] Left_Arm_Calibrator cannot perform 'check hardware fault' operation because joint number 9 is out of range [].
[DEBUG] Left_Arm_Calibrator : Joints calibration order:
[WARNING] Left_Arm_Calibrator  is calibrating only a subset of the robot part. 

After


[DEBUG] left_arm-calibrator starting calibration of device left_arm-mc_remapper
[INFO] Left_Arm_Calibrator : starting calibration
[DEBUG] Left_Arm_Calibrator : Joints calibration order: 4 5 6 3 2 0 1 7 8 10 11 12
[WARNING] Left_Arm_Calibrator  is calibrating only a subset of the robot part. Calibrating  12  over a total of  13

Now checkHWFault verifies fault on all configured joints insted of joint in (0, totJointsToCalibrate) and the calibJointsString contains the list of joint to calibrate
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me 👍🏻
I'll wait a short while to see whether @marcoaccame is available for a second review.

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK by me

@pattacini pattacini changed the base branch from devel to master April 28, 2023 08:31
@pattacini pattacini changed the base branch from master to devel April 28, 2023 08:32
@pattacini pattacini merged commit b6eb36d into robotology:devel Apr 28, 2023
pattacini pushed a commit that referenced this pull request Apr 28, 2023
@valegagge valegagge deleted the fix/CalibratorEth branch June 28, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants