Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for detecting continous joints and fix r_wrist_yaw of icub3 generated as continous joint #214

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Dec 3, 2021

After adding this, and running ctest --output-on-failure you get:

Test project /home/ngenesio/robotology/icub-model-generator/build
      Start  1: iCubGenova03ConsistencyCheck
 1/16 Test  #1: iCubGenova03ConsistencyCheck ..........   Passed    0.01 sec
      Start  2: iCubNancy01ConsistencyCheck
 2/16 Test  #2: iCubNancy01ConsistencyCheck ...........   Passed    0.01 sec
      Start  3: iCubParis01ConsistencyCheck
 3/16 Test  #3: iCubParis01ConsistencyCheck ...........   Passed    0.01 sec
      Start  4: iCubParis02ConsistencyCheck
 4/16 Test  #4: iCubParis02ConsistencyCheck ...........   Passed    0.01 sec
      Start  5: iCubLisboa01ConsistencyCheck
 5/16 Test  #5: iCubLisboa01ConsistencyCheck ..........   Passed    0.01 sec
      Start  6: iCubGazeboV2_5ConsistencyCheck
 6/16 Test  #6: iCubGazeboV2_5ConsistencyCheck ........   Passed    0.01 sec
      Start  7: iCubGazeboV2_6ConsistencyCheck
 7/16 Test  #7: iCubGazeboV2_6ConsistencyCheck ........   Passed    0.01 sec
      Start  8: iCubGazeboV2_7ConsistencyCheck
 8/16 Test  #8: iCubGazeboV2_7ConsistencyCheck ........   Passed    0.01 sec
      Start  9: iCubGazeboV2_5_plusConsistencyCheck
 9/16 Test  #9: iCubGazeboV2_5_plusConsistencyCheck ...   Passed    0.01 sec
      Start 10: iCubGazeboV3ConsistencyCheck
10/16 Test #10: iCubGazeboV3ConsistencyCheck ..........***Failed    0.01 sec
[WARNING] SensorElement :: setAttributes : iDynTree does not support sensor of type depth
[WARNING] SensorElement :: setAttributes : iDynTree does not support sensor of type camera
icub-model-test error: r_wrist_yaw is a continous joint

      Start 11: iCubGenova01ConsistencyCheck
11/16 Test #11: iCubGenova01ConsistencyCheck ..........   Passed    0.01 sec
      Start 12: iCubGenova02ConsistencyCheck
12/16 Test #12: iCubGenova02ConsistencyCheck ..........   Passed    0.01 sec
      Start 13: iCubGenova04ConsistencyCheck
13/16 Test #13: iCubGenova04ConsistencyCheck ..........   Passed    0.01 sec
      Start 14: iCubGenova09ConsistencyCheck
14/16 Test #14: iCubGenova09ConsistencyCheck ..........***Failed    0.01 sec
[WARNING] SensorElement :: setAttributes : iDynTree does not support sensor of type depth
[WARNING] SensorElement :: setAttributes : iDynTree does not support sensor of type camera
icub-model-test error: r_wrist_yaw is a continous joint

      Start 15: iCubErzelli02ConsistencyCheck
15/16 Test #15: iCubErzelli02ConsistencyCheck .........   Passed    0.01 sec
      Start 16: iCubDarmstadt01ConsistencyCheck
16/16 Test #16: iCubDarmstadt01ConsistencyCheck .......   Passed    0.01 sec

88% tests passed, 2 tests failed out of 16

Total Test time (real) =   0.18 sec

The following tests FAILED:
         10 - iCubGazeboV3ConsistencyCheck (Failed)
         14 - iCubGenova09ConsistencyCheck (Failed)

This would avoid that something like robotology/icub-models#93 happens

@Nicogene Nicogene self-assigned this Dec 3, 2021
@Nicogene Nicogene changed the title Test: add a check for detecting continous joints Add a check for detecting continous joints and fix r_wrist_yaw of icub3 generated as continous joint Dec 3, 2021
@traversaro
Copy link
Member

Great!

@traversaro traversaro merged commit d0a98d8 into master Dec 3, 2021
@traversaro traversaro deleted the feat/addCheckOnRevoluteJoints branch December 3, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants