-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline example #27
Pipeline example #27
Conversation
The homebrew failure is not related to this repo, but rather to actions/runner-images#2391 or actions/runner-images#2322 . We can add some workarounds, but given the frequency of this incidents I think we can also just disable macOS testing for now. |
6f8e02f
to
22454fa
Compare
@AlexAntn can you please write down the discussion in today's meeting? Thanks! |
In the meeting, we discussed the use of a circular buffer, and whether it makes sense to copy the contents read from a buffer to a "local collection" vector. In practice, if we make the buffer large enough and also specify a threshold at which it writes the data to a file, it should be possible to work just with the circular buffer (for example, the circular buffer could have a capacity for 300 entries of data, and a threshold for saving to the file at 200, allowing still 100 entries to write new data without losing any data). Another aspect is the saving of the file when something happens (e.g.: ctrl+c or a segmentation fault exception). This might require using yarp modules or checking how to do it in a OS-independent way. I will implement these changes and update the PR. |
As stated here the ideas that came out from the latest meeting has been implemented in the high-level API. |
Ok for me! |
After working with Nicolo in the morning, we came up with a small example of the full pipeline, from a data vector to circular buffer, then reading from the circular buffer and creating a mat file with matioCpp.
The reading is done in a thread, made safe by use of mutex locks. The data is stored in a local collection, and the mat file is created at the end of the run (when the user chooses to terminate the module).
This already uses the Buffer API developed by @Nicogene