Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workarounds to fix Homebrew CI #566

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Add workarounds to fix Homebrew CI #566

merged 4 commits into from
Dec 22, 2020

Conversation

traversaro
Copy link
Member

Fix #565 .

@traversaro
Copy link
Member Author

The workaround is working. The Homebrew CI is now failing for another reason (that is currently tracked in osrf/homebrew-simulation#1235), but I think we can merge this PR.

@traversaro traversaro changed the title Add workaround to install python@3.9 on Homebrew Add workarounds to fix Homebrew CI Dec 22, 2020
@traversaro
Copy link
Member Author

I also added a workaround for osrf/homebrew-simulation#1235 taken from gazebo-tooling/release-tools#366 .

@lrapetti
Copy link
Member

I also added a workaround for osrf/homebrew-simulation#1235 taken from ignition-tooling/release-tools#366 .

Thanks @traversaro,
is the failure we see on macOS-11 related, or is it something new?

@traversaro
Copy link
Member Author

I also added a workaround for osrf/homebrew-simulation#1235 taken from ignition-tooling/release-tools#366 .

Thanks @traversaro,
is the failure we see on macOS-11 related, or is it something new?

The failure affects both 10.15 and 11.0 . It is related to the latest Boost relaese on Homebrew (1.75, see osrf/homebrew-simulation#1235).

@traversaro
Copy link
Member Author

The only two failures are two network flakes, I think we can merge.

@traversaro traversaro merged commit 1640c2f into master Dec 22, 2020
@traversaro traversaro deleted the fix-macos-ci branch December 22, 2020 16:59
@traversaro traversaro mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrapetti lrapetti lrapetti approved these changes

@kouroshD kouroshD Awaiting requested review from kouroshD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS Homebrew CI failing
2 participants
@traversaro @lrapetti