Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix: Update inputs #165

Merged
merged 2 commits into from
May 27, 2023
Merged

Nix: Update inputs #165

merged 2 commits into from
May 27, 2023

Conversation

Julow
Copy link
Contributor

@Julow Julow commented May 25, 2023

The package requires a more recent version of opam-repository, the lock file has to be updated.

@hannesm
Copy link
Collaborator

hannesm commented May 25, 2023

thanks. two questions:
(1) the nix build fails:

error (ignored): error: end of string reached
error:
       … while evaluating the attribute 'defaultPackage'

         at /nix/store/qrsm81kzz217an4wbqh05qr2dcldpkv5-source/flake.nix:40:9:

           39|         packages = { inherit albatross; };
           40|         defaultPackage = albatross;
             |         ^
           41|

       … while evaluating the attribute 'pkgs'

         at /nix/store/j9avmdn9rv5f465s2jc15as8idi43sp9-source/flake.nix:72:18:

           71|         opam-nix = import ./src/opam.nix {
           72|           inherit pkgs opam-repository opam-overlays mirage-opam-overlays;
             |                  ^
           73|         };

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: getting status of '/nix/store/zgdl7i7p1slw1nn8cxl183xsn452kbmp-nixpkgs': No such file or directory

(2) why is there "opam-overlays" and "mirage-overlays"? this package should be fine with only the opam-repository.

@Julow
Copy link
Contributor Author

Julow commented May 25, 2023

The flake no longer builds with Nix 2.15 for some reason. I'm debugging this. I'm considering pinning version 2.11 in CI as 2.15 is very recent and not everyone can have it easily.

opam-overlays and mirage-overlays are dependencies of opam-nix even though they are only used to be added to the solver input. With some configuration, we could remove them from the solver inputs but they are still marked as dependencies to opam-nix.

@hannesm
Copy link
Collaborator

hannesm commented May 25, 2023

Thanks for your prompt reply. Sticking to an older nix release sounds fine, as does keeping the overlay repository if "opam-nix" needs them anyways.

@Julow
Copy link
Contributor Author

Julow commented May 25, 2023

The version of Nix was not the problem. It was actually an interaction with my local config, hopefully fixed.

opam-nix doesn't internally need the two overlays but instead assumes all packages need them. This seems to have been added in tweag/opam-nix#18

@Julow
Copy link
Contributor Author

Julow commented May 25, 2023

CI is green!

I have opened an issue about the overlay repositories: tweag/opam-nix#43

@Julow
Copy link
Contributor Author

Julow commented May 26, 2023

It has been suggested that we don't need to control the two overlays dependencies in (tweag/opam-nix#43 (comment)) so I'll remove them to clean up flake.nix.

@hannesm hannesm merged commit f10b3cd into robur-coop:main May 27, 2023
@hannesm
Copy link
Collaborator

hannesm commented May 27, 2023

thanks a lot

@hannesm
Copy link
Collaborator

hannesm commented May 27, 2023

ocaml-ci failures are unrelated ("Cancelled"), and clicking on the url for more details returns an internal server error (500) at the ocaml-ci site... luckily we have github actions & cirrus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants