add an optional behaviour to flush all pending data in the internal b… #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Driver.hpp
Outdated
| @@ -358,6 +407,13 @@ class Driver | |||
| */ | |||
| int readPacket(uint8_t* buffer, int bufsize, int packet_timeout, int first_byte_timeout = -1); | |||
|
|
|||
| /** @overload @deprecated | |||
There was a problem hiding this comment.
Why is this function deprecated already ?
There was a problem hiding this comment.
Because I copy/pasted the documentation from the readPacket above (which is deprecated). I'm going to refactor that stuff to overload the non-deprecated readPacket that uses base::Time for timeouts) and update.
|
Okay, so we wait with the merge until the final refactoring ? |
Well ... that's the whole point of pull requests, ain't it ? |
…uffer on timeout This is required in cases where it is expected that corrupted data would come in (i.e. corrupting medium). Otherwise, the driver might get stuck at a broken packet, trying forever for data. The behaviour, when enabled, is to try and read packets from the immediately available data, discarding everything that is not a full packet -- it would for instance discard a partial packet.
And deprecate the ones that were still using integers (milliseconds). Timeout::timeLeft has been renamed into remaining in the Time-using API to keep backward compatibility.
doudou
force-pushed
the
flush_read_buffer_on_timeout
branch
from
401cec7
to
404eac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uffer on timeout
This is required in cases where it is expected that corrupted data
would come in (i.e. corrupting medium). Otherwise, the driver might get
stuck at a broken packet, trying forever for data.
The behaviour, when enabled, is to try and read packets from the
immediately available data, discarding everything that is not a full
packet -- it would for instance discard a partial packet.