Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove devscripts installation from install R scripts to reduce container size #510

Closed
eitsupi opened this issue Jul 21, 2022 · 3 comments · Fixed by #511
Closed

Remove devscripts installation from install R scripts to reduce container size #510

eitsupi opened this issue Jul 21, 2022 · 3 comments · Fixed by #511

Comments

@eitsupi
Copy link
Member

eitsupi commented Jul 21, 2022

Tracking this discussion, I see that rocker/drd doesn't like the devscripts dependencies (like python3) and only extracts checkbashisms and includes it in the source code.

rocker-org/rocker-versioned#167 (comment)
https://github.com/rocker-org/drd/blob/06ab465832ab7c77335d16f9e934d03bdb0493c4/checkbashisms

I suppose we could do the same thing here.

Originally posted by @eitsupi in #507 (comment)

@cboettig
Copy link
Member

Right, I guess maybe there are some concerns with this not coming from the official ubuntu repo, not sure if that has any chance of interacting with version issues or whatnot. I do recall devscripts is kinda big, but then I think some of the other deps there might be used implicitly in later images too, so this could have downstream impacts on the stack? Maybe more evaluation is needed here.

@eitsupi
Copy link
Member Author

eitsupi commented Jul 22, 2022

Yeah, I think we need to update the tests to at least make sure rocker_scripts can run.

@eitsupi
Copy link
Member Author

eitsupi commented Jul 23, 2022

I guess maybe there are some concerns with this not coming from the official ubuntu repo

I think we can temporarily install the devscripts as $BUILDDEPS, copy the checkbashisms file (/usr/bin/checkbashisms) locally (to /usr/local/bin/checkbashisms, as like rocker/drd), and then remove devscripts as $BUILDDEPS.
Let's try this.

BUILDDEPS="curl \
default-jdk \
libbz2-dev \
libcairo2-dev \
libcurl4-openssl-dev \
libpango1.0-dev \
libjpeg-dev \
libicu-dev \
libpcre2-dev \
libpng-dev \
libreadline-dev \
libtiff5-dev \
liblzma-dev \
libx11-dev \
libxt-dev \
perl \
rsync \
subversion \
tcl-dev \
tk-dev \
texinfo \
texlive-extra-utils \
texlive-fonts-recommended \
texlive-fonts-extra \
texlive-latex-recommended \
texlive-latex-extra \
x11proto-core-dev \
xauth \
xfonts-base \
xvfb \
wget \
zlib1g-dev"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants