Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

track created values and free on isolate dispose #86

Merged
merged 4 commits into from
Mar 10, 2021
Merged

Conversation

rogchap
Copy link
Owner

@rogchap rogchap commented Mar 9, 2021

Potential fixes #81
And builds upon work started in #82

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #86 (bc51ab1) into master (794781e) will increase coverage by 1.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   94.64%   96.50%   +1.86%     
==========================================
  Files          11       11              
  Lines         411      401      -10     
==========================================
- Hits          389      387       -2     
+ Misses         15        9       -6     
+ Partials        7        5       -2     
Impacted Files Coverage Δ
context.go 94.11% <ø> (-0.25%) ⬇️
value.go 97.48% <ø> (+2.39%) ⬆️
isolate.go 100.00% <100.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794781e...5b21c52. Read the comment docs.

@rogchap rogchap requested review from tmc and zwang March 9, 2021 08:40
Copy link
Collaborator

@zwang zwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwang zwang merged commit 387e66e into master Mar 10, 2021
@zwang zwang deleted the rm-finalizers branch March 10, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] segmentation violation panic after garbage collection
2 participants