Fix fabric8io#1112: portPropertyFile not written anymore

port mappings should be written after we start containers.
rohanKanojia · Jul 27, 2019 · 18a882b · 18a882b
1 parent a9c6f22
commit 18a882b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/doc/changelog.md b/doc/changelog.md
@@ -4,6 +4,7 @@
   - Fix test cases on Windows ([#1220](https://github.com/fabric8io/docker-maven-plugin/issues/1220))
   - ECR credentials from IAM Task role for ECS Fargate deployment ([#1233](https://github.com/fabric8io/docker-maven-plugin/issues/1233))
   - Fix bug in properties names extracted from docker config json file ([#1237](https://github.com/fabric8io/docker-maven-plugin/issues/1237))
+  - Fix #1112: portPropertyFile not written anymore
 
 * **0.30.0** (2019-04-21)
   - Restore ANSI color to Maven logging if disabled during plugin execution and enable color for Windows with Maven 3.5.0 or later. Color logging is enabled by default, but disabled if the Maven CLI disables color (e.g. in batch mode) ([#1108](https://github.com/fabric8io/docker-maven-plugin/issues/1108))

diff --git a/src/main/java/io/fabric8/maven/docker/StartMojo.java b/src/main/java/io/fabric8/maven/docker/StartMojo.java
@@ -297,11 +297,12 @@ private void startImage(final ImageConfiguration imageConfig,
 
         startingContainers.submit(() -> {
 
+            String containerId = startExecutor.startContainers();
+
             // Update port-mapping writer
             portMappingPropertyWriteHelper.add(portMapping, runConfig.getPortPropertyFile());
 
 
-            String containerId = startExecutor.startContainers();
 
             return new StartedContainer(imageConfig, containerId);
         });