From 50dc6a430c52552cb33fdc9986dab70801ca51c2 Mon Sep 17 00:00:00 2001
From: Rok Mihevc <rok@mihevc.org>
Date: Mon, 11 Dec 2023 16:05:12 +0100
Subject: [PATCH] Review feedback

---
 cpp/src/arrow/acero/util_test.cc       | 1 -
 cpp/src/arrow/c/bridge_test.cc         | 8 +++++++-
 python/pyarrow/src/arrow/python/gdb.cc | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/cpp/src/arrow/acero/util_test.cc b/cpp/src/arrow/acero/util_test.cc
index ec0a79d177cb9..caf3aedf08a1f 100644
--- a/cpp/src/arrow/acero/util_test.cc
+++ b/cpp/src/arrow/acero/util_test.cc
@@ -17,7 +17,6 @@
 
 #include "arrow/acero/hash_join_node.h"
 #include "arrow/acero/schema_util.h"
-#include "arrow/testing/extension_type.h"
 #include "arrow/testing/gtest_util.h"
 #include "arrow/testing/matchers.h"
 
diff --git a/cpp/src/arrow/c/bridge_test.cc b/cpp/src/arrow/c/bridge_test.cc
index ab6bfbad20b07..6f8a85c609fa1 100644
--- a/cpp/src/arrow/c/bridge_test.cc
+++ b/cpp/src/arrow/c/bridge_test.cc
@@ -2160,10 +2160,15 @@ TEST_F(TestSchemaImport, RunEndEncoded) {
 #endif
 
 TEST_F(TestSchemaImport, Dictionary) {
+  FillPrimitive("w:16");
+  c_struct_.metadata = kEncodedUuidMetadata.c_str();
+  auto expected = uuid();
+  CheckImport(expected);
+
   FillPrimitive(AddChild(), "u");
   FillPrimitive("c");
   FillDictionary();
-  auto expected = dictionary(int8(), utf8());
+  expected = dictionary(int8(), utf8());
   CheckImport(expected);
 
   FillPrimitive(AddChild(), "u");
@@ -3695,6 +3700,7 @@ TEST_F(TestSchemaRoundtrip, Dictionary) {
 }
 
 TEST_F(TestSchemaRoundtrip, UnregisteredExtension) {
+  TestWithTypeFactory(uuid, []() { return uuid(); });
   TestWithTypeFactory(complex128, []() {
     return struct_({::arrow::field("real", float64(), /*nullable=*/false),
                     ::arrow::field("imag", float64(), /*nullable=*/false)});
diff --git a/python/pyarrow/src/arrow/python/gdb.cc b/python/pyarrow/src/arrow/python/gdb.cc
index 6941769e4efe8..aa06d0eb15487 100644
--- a/python/pyarrow/src/arrow/python/gdb.cc
+++ b/python/pyarrow/src/arrow/python/gdb.cc
@@ -76,7 +76,7 @@ class UuidType : public ExtensionType {
     return Status::NotImplemented("");
   }
 
-  std::string Serialize() const override { return "uuid-serialized"; }
+  std::string Serialize() const override { return ""; }
 };
 
 std::shared_ptr<Array> SliceArrayFromJSON(const std::shared_ptr<DataType>& ty,