fix(rome_js_analyze): lint/correctness/noUndeclaredVariables incorrec…

…tly identifies AggregateError as an undeclared variable. #4365 (#4366) * fix(rome_js_analyze): lint/correctness/noUndeclaredVariables incorrectly identifies AggregateError as an undeclared variable. #4365 * fix(rome_js_analyze): lint/correctness/noUndeclaredVariables incorrectly identifies AggregateError as an undeclared variable. #4365
rome · Apr 11, 2023 · f1af02b · f1af02b
1 parent 3902f46
commit f1af02b
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -16,6 +16,7 @@
 - Code actions are formatted using Rome's formatter. If the formatter is disabled,
 the code action is not formatted.
 
+- Fix an issue when `noUndeclaredVariables` incorrectly identifies `AggregateError` as an undeclared variable. [#4365](https://github.com/rome/tools/issues/4365)
 #### New rules
 - [`noConfusingArrow`](https://docs.rome.tools/lint/rules/noConfusingArrow/)
 - [`noRedundantRoles`](https://docs.rome.tools/lint/rules/noRedundantRoles/)

diff --git a/crates/rome_js_analyze/src/globals/runtime.rs b/crates/rome_js_analyze/src/globals/runtime.rs
@@ -1,4 +1,5 @@
-pub const BUILTIN: [&str; 65] = [
+pub const BUILTIN: [&str; 66] = [
+    "AggregateError",
     "Array",
     "ArrayBuffer",
     "Atomics",
@@ -295,7 +296,8 @@ pub const ES_2020: [&str; 63] = [
     "valueOf",
 ];
 
-pub const ES_2021: [&str; 65] = [
+pub const ES_2021: [&str; 66] = [
+    "AggregateError",
     "Array",
     "ArrayBuffer",
     "Atomics",

diff --git a/...es/rome_js_analyze/tests/specs/correctness/noUndeclaredVariables/noUndeclaredVariables.js b/...es/rome_js_analyze/tests/specs/correctness/noUndeclaredVariables/noUndeclaredVariables.js
@@ -9,4 +9,5 @@ assignment = "value";
 // valid
 document;
 navigator;
-new ArrayBuffer();
+new ArrayBuffer();
+new AggregateError();
diff --git a/...me_js_analyze/tests/specs/correctness/noUndeclaredVariables/noUndeclaredVariables.js.snap b/...me_js_analyze/tests/specs/correctness/noUndeclaredVariables/noUndeclaredVariables.js.snap
@@ -16,6 +16,8 @@ assignment = "value";
 document;
 navigator;
 new ArrayBuffer();
+new AggregateError();
+
 ```
 
 # Diagnostics