This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_formatter): Format leading/trailing node comments with most outer node #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small refactor that implements `CommentStyle` on `FormatContext` to avoid the additional `S` type parameter for all token builders. This PR further simplifies the spacing handling between comments and tokens by fully delegating the spacing handling from the comments formatting to when a token gets formatted. This simplifies the overall logic.
Deploying with
|
| Latest commit: |
b014966
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3b5c9ecc.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-line-suffix-comment.tools-8rn.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR isn't ready yet. It considerably regresses performance and there are still a few instabilities when it comes to formatting comments. But it tries to address the first issue described in #2768 by formatting leading/trailing comments at the start/end of a node with the most outer node rather than the token.
I mainly want to put this up in case you hit any more instability issues while I'm on PTO and need an urgent fix. This should then be a good starting point.
CC: @leops @yassere @ematipico
Test Plan