This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(ci): fix the release workflows for the stable release #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.
|
MichaReiser
approved these changes
Nov 8, 2022
Comment on lines
-50
to
-51
| env: | ||
| prerelease: true |
There was a problem hiding this comment.
Interesting: Does env only apply to the current step? Can you double check the lsp release, it uses env: too
There was a problem hiding this comment.
Yes it seems the env attribute is scoped to whatever "build object" it's specified on, so here it was only defined for this specific step. In the LSP workflow env is specified for the whole build jobs so it should work correctly
jeysal
added a commit
to jeysal/rometools
that referenced
this pull request
Nov 8, 2022
* upstream/main: fix(ci): fix the release workflows for the stable release (rome#3583) Fix logo container margin Fix mobile docs regressions perf: End-to-end Linter and Formatter benchmarks (rome#3570) doc: VS Code extension (rome#3579) refactor(rome_cli): refactor the threading of parallel traversal to increase occupancy (rome#3577) [docs] Add navigation dropdown for docs (rome#3578) doc(rome_cli): Document `--files-max-size` option perf(rome_js_semantic): Use FX Hash function (rome#3565) fix(rome_js_analyzer): `noInvalidConstructorSuper` false positive for class expressions (rome#3561) Clean up mobile navigation doc(website): Run `cargo lintdoc` (rome#3567) doc: Fix install command Fix mobile code blocks Fix dark mode logo Update links Implement new website (rome#3556)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a few changes to the release workflows before the stable release:
romenpm package under thelatesttag instead ofnextprereleaseenvironment variable is correctly exported in CLI nightly buildsjs-apiusing its path instead of package nameTest Plan
Test run of the
release_cliworkflow: https://github.com/rome/tools/actions/runs/3418383900Test run of the
release_js_apiworkflow: https://github.com/rome/tools/actions/runs/3418397143