From 89e54d1ce9446ba2df518f3c5ccf9b352a3239fe Mon Sep 17 00:00:00 2001 From: Carsten Burgard Date: Fri, 1 Apr 2022 14:04:49 +0200 Subject: [PATCH 1/2] added missing snapshot creation --- roofit/hs3/src/RooJSONFactoryWSTool.cxx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/roofit/hs3/src/RooJSONFactoryWSTool.cxx b/roofit/hs3/src/RooJSONFactoryWSTool.cxx index 5f33a25b013ba..f718ea73fe857 100644 --- a/roofit/hs3/src/RooJSONFactoryWSTool.cxx +++ b/roofit/hs3/src/RooJSONFactoryWSTool.cxx @@ -1728,13 +1728,16 @@ void RooJSONFactoryWSTool::importAllNodes(const RooFit::Experimental::JSONNode & std::string name = RooJSONFactoryWSTool::name(snsh); if (name == "fromJSON") continue; + RooArgSet vars; for (const auto &var : snsh.children()) { std::string vname = RooJSONFactoryWSTool::name(var); RooRealVar *rrv = this->_workspace->var(vname); if (!rrv) continue; this->configureVariable(var, *rrv); + vars.add(*rrv); } + this->_workspace->saveSnapshot(name.c_str(),vars); } } this->_workspace->loadSnapshot("fromJSON"); From c478306549e7171862fed77fa4b37ce8dd275008 Mon Sep 17 00:00:00 2001 From: Carsten Burgard Date: Mon, 4 Apr 2022 16:35:00 +0200 Subject: [PATCH 2/2] clang-fixes --- roofit/hs3/src/RooJSONFactoryWSTool.cxx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/roofit/hs3/src/RooJSONFactoryWSTool.cxx b/roofit/hs3/src/RooJSONFactoryWSTool.cxx index f718ea73fe857..206ed87e7d1c2 100644 --- a/roofit/hs3/src/RooJSONFactoryWSTool.cxx +++ b/roofit/hs3/src/RooJSONFactoryWSTool.cxx @@ -1728,16 +1728,16 @@ void RooJSONFactoryWSTool::importAllNodes(const RooFit::Experimental::JSONNode & std::string name = RooJSONFactoryWSTool::name(snsh); if (name == "fromJSON") continue; - RooArgSet vars; + RooArgSet vars; for (const auto &var : snsh.children()) { std::string vname = RooJSONFactoryWSTool::name(var); RooRealVar *rrv = this->_workspace->var(vname); if (!rrv) continue; this->configureVariable(var, *rrv); - vars.add(*rrv); + vars.add(*rrv); } - this->_workspace->saveSnapshot(name.c_str(),vars); + this->_workspace->saveSnapshot(name.c_str(), vars); } } this->_workspace->loadSnapshot("fromJSON");