Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WP_ENVIRONMENT_TYPE #668

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Support WP_ENVIRONMENT_TYPE #668

merged 1 commit into from
Feb 15, 2023

Conversation

voronkovich
Copy link
Contributor

This PR implements proposal suggested by @swalkinshaw: #627 (comment)

swalkinshaw
swalkinshaw reviewed Feb 15, 2023
View reviewed changes
README.md Outdated
@@ -84,6 +84,7 @@ Much of the philosophy behind Bedrock is inspired by the [Twelve-Factor App](htt
- `DB_HOST` - Database host
- Optionally, you can define `DATABASE_URL` for using a DSN instead of using the variables above (e.g. `mysql://user:password@127.0.0.1:3306/db_name`)
- `WP_ENV` - Set to environment (`development`, `staging`, `production`)
- `WP_ENVIRONMENT_TYPE` - Set to [environment type](https://developer.wordpress.org/reference/functions/wp_get_environment_type/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's omit this for now since by default it will be set automatically (and in ~98% of cases?). Don't want people thinking they need to set it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swalkinshaw , ok. I've removed that line from README.

@swalkinshaw swalkinshaw merged commit e14658b into roots:master Feb 15, 2023
@swalkinshaw
Copy link
Member

Thanks @voronkovich

@voronkovich voronkovich deleted the wp-environment-type branch February 15, 2023 22:33
This was referenced Feb 17, 2023
Closed
Closed
Closed
@yangm97
Copy link

yangm97 commented Feb 17, 2023

@swalkinshaw why this PR got merged instead of #543?

@swalkinshaw
Copy link
Member

That PR was outdated using the deprecated WP_ENVIRONMENT_TYPES (plural). It also set WP_ENV based on WP_ENVIRONMENT_TYPE which this only does the opposite so it's simpler.

@ethanclevenger91 ethanclevenger91 mentioned this pull request Mar 23, 2023
Open
5 tasks
mmoollllee added a commit to mmoollllee/bedrock that referenced this pull request Oct 25, 2023
@mmoollllee
Squashed commit of the following:
309be9f 
commit eead6f6
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Thu Oct 12 16:49:31 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.3.2 (roots#689)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit d5ee9d5
Author: Ben Word <ben@benword.com>
Date:   Tue Oct 10 19:25:07 2023 -0500

    📝 Update README [ci skip]

commit a90180a
Author: Ben Word <ben@benword.com>
Date:   Wed Sep 27 10:10:41 2023 -0500

    📝 Update README [ci skip]

commit 64a5624
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Aug 29 09:59:58 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.3.1 (roots#685)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 149bdab
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Aug 15 08:52:55 2023 -0500

    fix(deps): ⬆️ bump wpackagist-theme/twentytwentythree to v1.2 (roots#683)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 7aa70cd
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue Aug 8 17:14:03 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.3 (roots#682)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 50a86d4
Author: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date:   Sat Jul 15 20:32:00 2023 -0400

    Remove post install .env copy (roots#595)

    `.env.example` is just an example and doesn't contain useful defaults.
    Copying this file can be confusing since it needs to be edited
    regardless. By not copying this file, we'll surface errors of missing
    config values sooner since they'll be no default values.

commit 9223c3b
Author: Dareth NHANG <DSGND@users.noreply.github.com>
Date:   Tue Jun 13 20:04:50 2023 +0200

    Support `local` as `WP_ENVIRONMENT_TYPE` (roots#681)

commit 052bf9d
Author: Scott Walkinshaw <scott.walkinshaw@gmail.com>
Date:   Tue Jun 6 08:48:46 2023 -0400

    Add integration test workflow (roots#678)

commit 8bc7fb4
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon May 22 10:16:24 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.2.2 (roots#677)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 5993b4e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Tue May 16 15:40:25 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.2.1 (roots#676)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 96dbd4e
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Mon Apr 17 17:38:58 2023 -0500

    fix(deps): ⬆️ bump wpackagist-theme/twentytwentythree to v1.1 (roots#675)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit a4eb209
Author: Ben Word <ben@benword.com>
Date:   Wed Mar 29 16:38:02 2023 -0500

    🔥 Delete CHANGELOG

commit 6713c24
Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Date:   Wed Mar 29 16:36:38 2023 -0500

    fix(deps): ⬆️ bump roots/wordpress to v6.2 (roots#673)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

commit 09627b1
Author: Ben Word <ben@benword.com>
Date:   Tue Mar 7 18:30:36 2023 -0600

    📝 Update README [ci skip]

commit cbc53e0
Author: Ben Word <ben@benword.com>
Date:   Wed Mar 1 17:33:36 2023 -0600

    💡 Update comments

commit de66196
Author: Oleg Voronkovich <oleg-voronkovich@yandex.ru>
Date:   Wed Mar 1 20:53:06 2023 +0300

    Don't instantiate Dotenv if .env file not exists (roots#670)

commit 20167f3
Author: Ben Word <ben@benword.com>
Date:   Tue Feb 28 00:04:13 2023 -0600

    📝 Update README

commit e14658b
Author: Oleg Voronkovich <oleg-voronkovich@yandex.ru>
Date:   Thu Feb 16 01:31:08 2023 +0300

    Support WP_ENVIRONMENT_TYPE (roots#668)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalkinshaw swalkinshaw swalkinshaw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voronkovich @swalkinshaw @yangm97