Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --system-site-packages #66

Closed
wants to merge 2 commits into from
Closed

Remove --system-site-packages #66

wants to merge 2 commits into from

Conversation

tangrufus
Copy link
Member

@tangrufus tangrufus commented Sep 22, 2019 •
edited
Loading

@tangrufus tangrufus mentioned this pull request Sep 22, 2019
Merged
@tangrufus
Copy link
Member Author

tangrufus commented Sep 22, 2019 •
edited
Loading

CirlceCI is not building this pull request because Build forked pull requests is Off at https://circleci.com/gh/roots/trellis-cli/edit#advanced-settings

Any reason not to enable it?

@swalkinshaw
Copy link
Member

I think before they hadn't separated out the option below it (the secrets one) so this option was said to be dangerous. I enabled that one but not the secrets one 🤷‍♂

I fixed this up in #55 anyway but thanks 😄

@tangrufus tangrufus deleted the virtualenv-support branch September 28, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangrufus @swalkinshaw