Featute/Sign Up UI #58
Conversation
| && password.isNotEmpty() && !showPasswordError && | ||
| confirmPassword.isNotEmpty() && !showConfirmPasswordError | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
please don't forget to add a new line here
| @Preview | ||
| @Composable | ||
| fun SignUpScreen( | ||
| viewModel: SignUpViewModel = SignUpViewModel(), |
There was a problem hiding this comment.
don't we have any DI framework into the base yet? if so, might be better to use it. What do you think?
| <string name="sign_up_name_error">Name not valid</string> | ||
| <string name="sign_up_confirm_password_label">Confirm Password</string> | ||
| <string name="sign_up_confirm_password_error">Passwords don\'t match</string> | ||
| <string name="sign_up_button">SIGN UP</string> |
There was a problem hiding this comment.
Please capitalize only first letter Sign up. Then use .uppercase() in the code if needed
hrodrick
left a comment
hrodrick
left a comment
There was a problem hiding this comment.
Nice work! Just left a comment
| import com.rootstrap.androidcomposebase.ui.pages.sign_up.SignUpScreen | ||
| import com.rootstrap.androidcomposebase.ui.pages.sign_up.SignUpViewModel |
There was a problem hiding this comment.
remove this if not needed.
| val name: String = "", | ||
| val showNameError: Boolean = false, | ||
| val email: String = "", | ||
| val showEmailError: Boolean = false, | ||
| val password: String = "", | ||
| val showPasswordError: Boolean = false, | ||
| val confirmPassword: String = "", | ||
| val showConfirmPasswordError: Boolean = false, |
There was a problem hiding this comment.
I'd rename:
name -> nameInput
email -> emailInput
password -> passwordInput
confirmPassword -> confirmPasswordInput
| import kotlinx.coroutines.flow.update | ||
| import java.util.regex.Pattern | ||
|
|
||
| class SignUpViewModel : ViewModel() { |
There was a problem hiding this comment.
before merging wait for the previous PR
#57
and reuse the state management logic,
if need more context write to @agustinkoll-rootstrap
amaury901130
left a comment
amaury901130
left a comment
There was a problem hiding this comment.
wait for the previous PR
#57
ISSUE [#6]
Description
Tasks
SignUpScreenSIGN UPbuttonSignUpViewModelPreview
device-2023-08-16-150431.mp4
Notes