Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

rmangal blogpost #525

Merged
merged 35 commits into from
Oct 21, 2019
Merged

rmangal blogpost #525

merged 35 commits into from
Oct 21, 2019

Conversation

KevCaz
Copy link
Contributor

@KevCaz KevCaz commented Oct 15, 2019

Hi @stefaniebutland,

  • Here is the post we wrote with @SteveViss.
  • History is a bit chaotic but I guess we'll rebase/squash everything at the end am I write?
  • The first commit I did was meant to fix a typo in the readme.

Let me know what we can do to improve the post!

Copy link
Collaborator

@stefaniebutland stefaniebutland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevCaz @SteveViss I loved reading this post. Clear, concise, and easy for readers to relate to it. The intro said exactly what it needed to say to help readers. Nice work and proud to have it on the blog!! Also clear that you followed the instructions in linking to the review, reviewers etc so thank you for that. Thanks also for the README fix.

I made most of my (minor) suggestions in GitHub's commit suggestions so you can commit those directly if you agree.

When going through my comments, please give a 👍🏼 or 👎🏼 in the GitHub web interface so I know you've seen it, and "resolve conversation". Note that in a long list of comments some will be hidden so you might need to click to reveal them.

Please suggest any tweets or accounts to tag in a tweet, your conference poster # etc that I can use to supplement the standard rOpenSci tweets about your post.

Thank you!

content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
content/blog/2019-10-21-rmangal.md Outdated Show resolved Hide resolved
@KevCaz
Copy link
Contributor Author

KevCaz commented Oct 16, 2019

@stefaniebutland ! 💯 Great suggestions! all 👍 ! How do you want to procede for the 3 comments that require more text edition?

@stefaniebutland
Copy link
Collaborator

For the items where I made GitHub commit suggestions, please commit those
Screen Shot 2019-10-16 at 3 40 20 PM

How do you want to procede for the 3 comments that require more text edition?

Since the bulk of this is done, I'm happy to review additions on Thursday or early Friday, or on the weekend if necessary.

@stefaniebutland
Copy link
Collaborator

Click "Load more" to see additional comments
Screen Shot 2019-10-16 at 3 52 35 PM

Kevin Cazelles and others added 6 commits October 16, 2019 16:42
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
@KevCaz
Copy link
Contributor Author

KevCaz commented Oct 16, 2019

To do:

@stefaniebutland
Copy link
Collaborator

stefaniebutland commented Oct 16, 2019

  • view "hidden conversations" in this page (see screenshot above) for other comments in initial review, and commit and resolve conversations

@KevCaz
Copy link
Contributor Author

KevCaz commented Oct 16, 2019

view "hidden conversations" in this page
Oops!

Kevin Cazelles and others added 6 commits October 16, 2019 17:48
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Kevin Cazelles and others added 6 commits October 16, 2019 18:01
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
@KevCaz
Copy link
Contributor Author

KevCaz commented Oct 16, 2019

  • add links at the end of the post see comment:

Good here to link to pkg, API and site one last time in this sentence

  • use ecosystem functioning
  • remove link to first version

@SteveViss
Copy link

SteveViss commented Oct 17, 2019

Hi @stefaniebutland, thank you so much for your time. We have made all of the changes that you suggested (see the commits). Feel free if you need anything else from our side.

This image is great in that it gives a glimpse of what the tool gives a user. However, it made me crave the ability to zoom in and explore. Any way you can link to that specific example in the site https://mangal.io/#/network? Would help readers quickly get a deeper understanding.

It's unfortunate, but It will require more work on the website to be able to link with an R example and I will not have the time before the congress ;)

SteveViss and others added 3 commits October 17, 2019 09:10
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
Co-Authored-By: Stefanie Butland <stefaniebutland@gmail.com>
@stefaniebutland
Copy link
Collaborator

Looks like you've pushed all my suggestions now and this awesome post is ready to publish as dated, Monday Oct 21. 🎉😊🙌🏼

Let me know any conference details you'd like in tweets. If there's a specific timezone/time that's ideal let me know and I'll try to accommodate that.

@KevCaz
Copy link
Contributor Author

KevCaz commented Oct 17, 2019

Thanks a lot @stefaniebutland !

@stefaniebutland stefaniebutland merged commit 0e21712 into ropensci-archive:master Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants