Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document options to keep the README up-to-date #15

Closed
maelle opened this issue Nov 5, 2020 · 9 comments
Closed

document options to keep the README up-to-date #15

maelle opened this issue Nov 5, 2020 · 9 comments

Comments

@maelle
Copy link
Member

maelle commented Nov 5, 2020

E.g. link to GitHub Action workflows that knit the README on schedule (as we have in ropensci/software-review) https://github.com/ropensci/software-review/blob/master/.github/workflows/main.yml

@mpadge
Copy link
Member

mpadge commented Nov 5, 2020

Yeah, great idea. It shall be done. Thank you!

@maelle
Copy link
Member Author

maelle commented Oct 11, 2024

@mpadge friendly reminder

@mpadge
Copy link
Member

mpadge commented Oct 11, 2024

Oh yeah, thank you!!

@mpadge
Copy link
Member

mpadge commented Nov 18, 2024

First workflow run ran perfectly: https://github.com/ropensci/allcontributors/actions/runs/11894746363/job/33142671637.
I'll link to file in this repo as an example

@maelle
Copy link
Member Author

maelle commented Nov 18, 2024

another idea that could be mentioned, without CI: if you use usethis' release issue checklist, you can store custom items as an internal function. One item could be "run allcontributors". See https://usethis.r-lib.org/reference/use_release_issue.html#customization

mpadge added a commit that referenced this issue Nov 18, 2024
@mpadge
Copy link
Member

mpadge commented Nov 18, 2024

That's cool, but it doesn't really explain how it actually works. I guess that both

  1. The unexported function would have to be defined in this package? And but then
  2. The namespace of this package would have to be loaded for that function to work at all?

It's then not clear to me how that's actually supposed to work in practice? Any further insight appreciated!

@maelle
Copy link
Member Author

maelle commented Nov 18, 2024

  • you create the function in any package where you want the item to appear in checklists.
  • for releases you use usethis::use_release_issue() that opens an issue in the repository. An item would remind to update the allcontributors list.

@mpadge
Copy link
Member

mpadge commented Nov 18, 2024

Yeah, i figured it out, thanks. It's in usethis/R/release.R, where safe_pkg_env() loads current namespace. That means every package has to define one of those. I find that a bit clunky, but I guess worth documenting regardless. Thanks

mpadge added a commit that referenced this issue Nov 18, 2024
@mpadge mpadge closed this as completed Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants