Fix: Correct int64_t Format Specifier (MacOS)

[idesign0]

Fix: Correct int64_t Format Specifier and Set CMake Policy CMP0167

This PR resolves a C++ compilation error by correcting a format specifier mismatch in controller_interface/src/controller_interface_base.cpp.

• C++ Fix: Changed the format specifier from the incorrect %ld (long) to the proper %lld (long long/int64_t) in the logging statement to match the argument type.

[christophfroehlich]

Are you sure?
error: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Werror,-Wformat]

[idesign0]

Are you sure? error: format specifies type 'long long' but the argument has type 'int64_t' (aka 'long') [-Werror,-Wformat]

Yes, I saw that error. The root cause is the platform-dependent definition of int64_t — on macOS it resolves to long long (testing there). Thinking about a more portable fix now

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.62%. Comparing base (432ecad) to head (5afc131).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2817   +/-   ##
=======================================
  Coverage   89.62%   89.62%           
=======================================
  Files         152      152           
  Lines       17817    17817           
  Branches     1455     1455           
=======================================
  Hits        15968    15968           
  Misses       1263     1263           
  Partials      586      586           

Flag	Coverage Δ
unittests	89.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...roller_interface/src/controller_interface_base.cpp	82.58% <ø> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bmagyar]

I put MacOS in the title although I think it may have to do more with the architecture itself.

Here's an alternative idea @christophfroehlich : what if we drop -Werror=format from our cmake?

[christophfroehlich]

sure, we can do that

[saikishor]

@bmagyar @christophfroehlich instead of dropping the format flag, how about changing the update_rate parameter to size_t? or change the log to RCLCPP_WARN_STREAM?

[saikishor]

@christophfroehlich there is a failing pre-commit should we wait for it or merge and open a PR fixing it?

[christophfroehlich]

oops, no let's wait for the fix