Calculate achievable update rate of controllers

[saikishor]

No description provided.

[christophfroehlich]

Thanks for working on this. But this is a (maybe legit) behavior change, not only a fix for the tests, right?

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.61%. Comparing base (30416ba) to head (ac70c1b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...roller_interface/src/controller_interface_base.cpp	78.57%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2828      +/-   ##
==========================================
- Coverage   89.62%   89.61%   -0.01%     
==========================================
  Files         152      152              
  Lines       17817    17831      +14     
  Branches     1455     1457       +2     
==========================================
+ Hits        15968    15980      +12     
- Misses       1263     1264       +1     
- Partials      586      587       +1     

Flag	Coverage Δ
unittests	89.61% <83.33%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ntroller_interface/controller_interface_params.hpp	100.00% <ø> (ø)
...oller_interface/test/test_controller_interface.cpp	100.00% <100.00%> (ø)
controller_manager/src/controller_manager.cpp	77.09% <100.00%> (+0.06%)	⬆️
...ontroller_manager/test/test_controller_manager.cpp	96.22% <100.00%> (ø)
...roller_interface/src/controller_interface_base.cpp	82.03% <78.57%> (-0.55%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[saikishor]

Thanks for working on this. But this is a (maybe legit) behavior change, not only a fix for the tests, right?

Yup, I think it is a good fix in general and can be backported too IMHO. Because, if you internally use the update_rate inside your code and have a weird value as the update rate, then your logic might be messed up with what's happening in reality

[christophfroehlich]

I like. Maybe worth a release note?

[christophfroehlich]

Thx