Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

driver_common sources not listed in distribution.yaml for jade #9

Open
tkruse opened this issue Jul 30, 2015 · 5 comments
Open

driver_common sources not listed in distribution.yaml for jade #9

tkruse opened this issue Jul 30, 2015 · 5 comments

Comments

@tkruse
Copy link

tkruse commented Jul 30, 2015

To reproduce:

$ rosinstall_generator desktop_full --rosdistro jade --deps --wet-only  --upstream-development
The following repositories with an unknown upstream will be ignored: driver_common, laser_filters, metapackages, rosbag_migration_rule, stage

Also see
ros/filters#11

@jack-oquin
Copy link
Member

This is marked EoL in the ROS wiki:

Maintainer status: end-of-life (Will be released only as long as required for PR2 
                                drivers (hokuyo_node, wge100_driver))

I've got minor dependencies on driver_base in camera1394, which is also not yet released in Jade. That dependency can easily be removed, but had never seemed worth the effort (ros-drivers/camera1394#18).

I am not averse to releasing it again in Jade. That seems somewhat the easiest option. But, my minor dependency does not by itself justify keeping it around.

@tfoote
Copy link

tfoote commented Jul 31, 2015

This doesn't need a rerelease, it's already there. It just needs a source entry in the stanza: https://github.com/ros/rosdistro/blob/master/jade/distribution.yaml#L498

@k-okada
Copy link

k-okada commented Oct 25, 2016

how about releasing to kinetic? or should we remove dependency to driver_base from our code?

@jack-oquin
Copy link
Member

At this point, I suspect the path of least resistance is to keep it in Kinetic, and maybe remove it in ROS2.

@k-okada
Copy link

k-okada commented Oct 27, 2016

thanks, opened a ticket to ask for a kinetic release -> ros-gbp/driver_common-release#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants