Fixed timestamps #272
Merged
Fixed timestamps #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@jaimesx thanks for the contribution! I'm not the maintainer for the ROS 1 side but I'll go ahead and run the CI / approve if it passes since this is a bug fix. |
|
fyi @twdragon I am going to go ahead and merge this for the ROS 1 branch as it fixes a timestamp bug. |
|
this PR collaped
|
|
@flynneva |
|
Oh sorry, this PR is not the main cause of this collaption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi All,
I confirmed that the timestamps issues fixed by pull request #267 are also present in this branch. Now, rostopic delay does not show negative delays as expected.
before:
after:
