Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to colcon-core 0.18.1 #212

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Update to colcon-core 0.18.1 #212

merged 2 commits into from
Sep 30, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Sep 26, 2024

@cottsay cottsay self-assigned this Sep 26, 2024
nuclearsandwich
nuclearsandwich approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was some discussion that there are issues with tomli on Focal so you may opt not to merge this, but if you do or want to use this for an update after dropping focal, works for me.

@cottsay cottsay changed the title Update to colcon-core 0.18.0 Update to colcon-core 0.18.1 Sep 27, 2024
@cottsay cottsay merged commit 85f38ab into master Sep 30, 2024
1 check passed
@cottsay cottsay deleted the cottsay/colcon-core-0.18.0 branch September 30, 2024 18:32
@cottsay
Copy link
Member Author

cottsay commented Sep 30, 2024

Build Status
Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

@j-rivero j-rivero Awaiting requested review from j-rivero

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich