Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky spin, backup behavior test #4349

Closed
4 of 5 tasks
SteveMacenski opened this issue May 16, 2024 · 1 comment
Closed
4 of 5 tasks

Fix flaky spin, backup behavior test #4349

SteveMacenski opened this issue May 16, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SteveMacenski
Copy link
Member

SteveMacenski commented May 16, 2024

Test removed so that CI is green for contributors. Rewriting this test completely is probably required, this is over complicated, fragile, and tries to fake out / bypass parts of things I don't really understand why. We should just populate a costmap, call the server, check results and call it a day.

Removed in: #4348

Rewrite the behavior tests using GZ, the Simple Commander API and call this a day.

  • spin
  • backup
  • drive on heading
  • wait
  • teleop
@SteveMacenski SteveMacenski added the help wanted Extra attention is needed label May 16, 2024
@SteveMacenski SteveMacenski changed the title Fix flaky spin test Fix flaky spin, backup behavior test Jun 27, 2024
@SteveMacenski SteveMacenski added the good first issue Good for newcomers label Jun 27, 2024
@SteveMacenski
Copy link
Member Author

Done in #4515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant