From 035fa6f71b227b86139f338b3c1b8f928015a783 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Thu, 30 Apr 2020 21:51:11 -0700 Subject: [PATCH 1/8] Ignore codecov paths in tests --- codecov.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/codecov.yml b/codecov.yml index c822efe456e..111d2d0059e 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,2 +1,5 @@ fixes: - "src/navigation2/::" + +ignore: + - "*/**/test/*" # ignore package test directories From 472b4dd9357c80fbf656f69ae888c606e655cafe Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Thu, 30 Apr 2020 21:59:12 -0700 Subject: [PATCH 2/8] adding missing string test case for stripping leading slash --- nav2_util/test/test_string_utils.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/nav2_util/test/test_string_utils.cpp b/nav2_util/test/test_string_utils.cpp index 20fc3d35bdb..fb93e2dc6eb 100644 --- a/nav2_util/test/test_string_utils.cpp +++ b/nav2_util/test/test_string_utils.cpp @@ -26,4 +26,5 @@ TEST(Split, SplitFunction) ASSERT_EQ(split("foo:bar:", ':'), Tokens({"foo", "bar", ""})); ASSERT_EQ(split(":", ':'), Tokens({"", ""})); ASSERT_EQ(split("foo::bar", ':'), Tokens({"foo", "", "bar"})); + ASSERT_TRUE(strip_leading_slash(std::string("/hi")) == std::string("hi")) } From 8dd42f2f39a415ff8c512146e325c9ed74e37f39 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 15:40:02 -0700 Subject: [PATCH 3/8] Update test_string_utils.cpp --- nav2_util/test/test_string_utils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nav2_util/test/test_string_utils.cpp b/nav2_util/test/test_string_utils.cpp index fb93e2dc6eb..d3e8b29d85e 100644 --- a/nav2_util/test/test_string_utils.cpp +++ b/nav2_util/test/test_string_utils.cpp @@ -26,5 +26,5 @@ TEST(Split, SplitFunction) ASSERT_EQ(split("foo:bar:", ':'), Tokens({"foo", "bar", ""})); ASSERT_EQ(split(":", ':'), Tokens({"", ""})); ASSERT_EQ(split("foo::bar", ':'), Tokens({"foo", "", "bar"})); - ASSERT_TRUE(strip_leading_slash(std::string("/hi")) == std::string("hi")) + ASSERT_TRUE(nav2_util::strip_leading_slash(std::string("/hi")) == std::string("hi")); } From 2b4018755be24d8b37880945052a7a0ddc47274c Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 16:24:49 -0700 Subject: [PATCH 4/8] Update test_string_utils.cpp --- nav2_util/test/test_string_utils.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/nav2_util/test/test_string_utils.cpp b/nav2_util/test/test_string_utils.cpp index d3e8b29d85e..488bd1ea006 100644 --- a/nav2_util/test/test_string_utils.cpp +++ b/nav2_util/test/test_string_utils.cpp @@ -12,6 +12,8 @@ // See the License for the specific language governing permissions and // limitations under the License. +#include + #include "nav2_util/string_utils.hpp" #include "gtest/gtest.h" From 895cf8d8d73aec509f3c609c2e0b4711c5e6f991 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 16:52:35 -0700 Subject: [PATCH 5/8] Update codecov.yml --- codecov.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 111d2d0059e..edd29fbd64f 100644 --- a/codecov.yml +++ b/codecov.yml @@ -2,4 +2,5 @@ fixes: - "src/navigation2/::" ignore: - - "*/**/test/*" # ignore package test directories + - "*/**/test/*" # ignore package test directories, e.g. nav2_dwb_controller/costmap_queue/tests + - "**/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests From 3400a917dcde98f3450863b4d62692884ffdd8eb Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 17:15:27 -0700 Subject: [PATCH 6/8] Update codecov.yml --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index edd29fbd64f..58b93c02756 100644 --- a/codecov.yml +++ b/codecov.yml @@ -3,4 +3,4 @@ fixes: ignore: - "*/**/test/*" # ignore package test directories, e.g. nav2_dwb_controller/costmap_queue/tests - - "**/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests + - "*/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests From b7f2ff22b1aee39855c963c153997a892f36497c Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 17:50:15 -0700 Subject: [PATCH 7/8] Update codecov.yml --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 58b93c02756..1f691f01aae 100644 --- a/codecov.yml +++ b/codecov.yml @@ -3,4 +3,4 @@ fixes: ignore: - "*/**/test/*" # ignore package test directories, e.g. nav2_dwb_controller/costmap_queue/tests - - "*/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests + - "**/*/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests From 2c3a89f9d2645cbeb4924e151db99d4b014159d3 Mon Sep 17 00:00:00 2001 From: Steve Macenski Date: Fri, 1 May 2020 18:40:17 -0700 Subject: [PATCH 8/8] Update codecov.yml --- codecov.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/codecov.yml b/codecov.yml index 1f691f01aae..01835eda004 100644 --- a/codecov.yml +++ b/codecov.yml @@ -3,4 +3,4 @@ fixes: ignore: - "*/**/test/*" # ignore package test directories, e.g. nav2_dwb_controller/costmap_queue/tests - - "**/*/test/*" # ignore package test directories, e.g. nav2_costmap_2d/tests + - "*/test/**/*" # ignore package test directories, e.g. nav2_costmap_2d/tests