Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating nmake inference rule problems #383

Merged
merged 1 commit into from
Mar 13, 2013

Conversation

stonier
Copy link
Contributor

@stonier stonier commented Mar 13, 2013

Problem

rostest's add_ros_test calls on windows would run through the cmake ok, but when hitting nmake, it would stop short with the error message:

makefile(1035) : fatal error U1086: inference rule cannot have dependents
Stop.

In the Makefile, you would find a target like:

.run_tests_rostest_rostest_test_hztest0.test: cmake_check_build_system
    $(MAKE) -f CMakeFiles\Makefile2 /nologo -$(MAKEFLAGS) .run_tests_rostest_rostest_test_hztest0.test

Nmake would read this like an inference rule (aka .c.obj:) and abort when it saw the dependency (http://msdn.microsoft.com/en-us/library/d8k6a82k.aspx).

Solution

Is there a special reason the hidden targets are using a dot? I've used underscore here.

@dirk-thomas
Copy link
Member

No specific reason why we selected .. _ should do the same job of hiding the target name on auto completion and work well with nmake.

dirk-thomas added a commit that referenced this pull request Mar 13, 2013
Avoid creating nmake inference rule problems
@dirk-thomas dirk-thomas merged commit cda60bd into ros:groovy-devel Mar 13, 2013
@stonier stonier deleted the patch-6 branch March 14, 2013 00:19
cwecht pushed a commit to cwecht/catkin that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants