Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add substitution args parsing to roslaunch yaml loaded from file #1051

Closed
DSsoto opened this issue May 9, 2017 · 2 comments
Closed

Add substitution args parsing to roslaunch yaml loaded from file #1051

DSsoto opened this issue May 9, 2017 · 2 comments

Comments

@DSsoto
Copy link

DSsoto commented May 9, 2017

@jbohren's #218 added resolving args in rosparam if the yaml text is inlined inside of the launch file.

However I have repeatedly found myself missing this feature when loading parameters from a external yaml file using rosparam's file attribute. Here is a minimal reproducible example of the issue.

config.yaml:

# This arg will not get substituted corrctly
subbed_pkg_from_file : $(find roscpp)

param_loader.launch:

<launch>
  <rosparam subst_value="true"> subbed_pkg : $(find roscpp) </rosparam>
  <rosparam subst_value="true" file="/home/santiago/config.yaml" />
</launch>

Output of roslaunch param_loader.launch --dump-params:

{/subbed_pkg: /opt/ros/kinetic/share/roscpp, /subbed_pkg_from_file: $(find roscpp)}

It would be very useful to actually have subbed_pkg_from_file resolve to the package path when subst_value is set to true.

@dirk-thomas
Copy link
Member

The maintainers will likely not have time to implement this in the foreseeable future. Please consider to contribute a pull request to implement this feature.

nano-meter added a commit to nano-meter/ros_comm that referenced this issue Mar 22, 2018
nano-meter added a commit to nano-meter/ros_comm that referenced this issue Mar 22, 2018
nano-meter added a commit to nano-meter/ros_comm that referenced this issue Mar 22, 2018
dirk-thomas pushed a commit that referenced this issue Apr 5, 2018
* Add substitution when loading yaml files

like in #1051

* Add tests
zachfang pushed a commit to 6RiverSystems/ros_comm that referenced this issue Jun 21, 2018
* Add substitution when loading yaml files

like in ros#1051

* Add tests
dantwinkler pushed a commit to 6RiverSystems/ros_comm that referenced this issue Jul 10, 2018
* Add substitution when loading yaml files (ros#1354)

* Add substitution when loading yaml files

like in ros#1051

* Add tests

* fix: add fix commit message

* fix: add jira ticket (PERCEPTION-1921)
@dirk-thomas
Copy link
Member

Implemented in #1354.

dirk-thomas pushed a commit that referenced this issue Aug 20, 2018
* Add substitution when loading yaml files

like in #1051

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants