Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wxwidgets key. #31699

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Update wxwidgets key. #31699

merged 3 commits into from
Jan 20, 2022

Conversation

nuclearsandwich
Copy link
Member

Since all supported Debian and Ubuntu distributions now provide this key
the distribution version/codename can be elided.

@nuclearsandwich nuclearsandwich self-assigned this Jan 6, 2022
@nuclearsandwich nuclearsandwich requested a review from a team as a code owner January 6, 2022 23:43
@github-actions github-actions bot added the rosdep Issue/PR is for a rosdep key label Jan 6, 2022
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a weird rename but it appears to be on all platforms.

Debian: https://packages.debian.org/buster/libwxgtk3.0-gtk3-dev
Ubuntu: https://packages.ubuntu.com/bionic/libwxgtk3.0-gtk3-dev

But digging in a little deeper the two ubuntu packages on bionic don't provide the same files:

https://packages.ubuntu.com/bionic/amd64/libwxgtk3.0-dev/filelist
vs https://packages.ubuntu.com/bionic/amd64/libwxgtk3.0-gtk3-dev/filelist which clearly is necessary to avoid installation collisions. But what is the difference between /usr/lib/x86_64-linux-gnu/libwx_gtk2u_adv-3.0.so and /usr/lib/x86_64-linux-gnu/libwx_gtk3u_adv-3.0.so

I suggest that we not fully collapse these rules but keep the new rule as a wildcard and make a special rule for existing platforms (bionic, stretch, and buster) with the existing keys. It's a little less cleanup, but will be much less likely to break someone.

@tfoote
Copy link
Member

tfoote commented Jan 12, 2022

We had an odd CI failure on this one failing in the setup stage: https://github.com/ros/rosdistro/runs/4784291694?check_suite_focus=true

Secret source: Actions
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v2' (SHA:ec3a7ce113134d7a93b817d10a8272cb61118579)
Error: Can't use 'tar -xzf' extract archive file: /home/runner/work/_actions/_temp_070005fe-2f62-415f-bc45-1589bccccde5/7c1f40d3-56ba-431c-b217-aa9c0dd95438.tar.gz. return code: 2.

Retriggering it now fails for two parallel issues

Error: Package 'gurumdds-2.6' could not be found for ubuntu jammy on amd64
Package 'gurumdds-2.7' for ubuntu bionic on amd64 was found: http://repos.ros.org/repos/ros_bootstrap/pool/main/g/gurumdds-2.7/gurumdds-2.7.3017-bionic-x86_64.deb
Package 'gurumdds-2.7' for ubuntu focal on amd64 was found: http://repos.ros.org/repos/ros_bootstrap/pool/main/g/gurumdds-2.7/gurumdds-2.7.3017-focal-x86_64.deb

Error: Package 'gurumdds-2.7' could not be found for ubuntu jammy on amd64

And soccer_visualization is out of date

======================================================================
FAIL: test_function (test.test_url_validity.TestUrlValidity)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/rosdistro/rosdistro/test/test_url_validity.py", line 380, in test_function
    self.assertFalse(detected_errors)
AssertionError: ["In file '''/home/runner/work/rosdistro/rosdistro/galactic/distribution.yaml''': Could not validate source entry for repo soccer_visualization with error [[[Could not validate repository with url https://github.com/ijnek/soccer_visualization.git and version main from entry at line 4525. Error reason: No branch found matching main]]]", "In file '''/home/runner/work/rosdistro/rosdistro/galactic/distribution.yaml''': Could not validate doc entry for repo soccer_visualization with error [[[Could not validate repository with url https://github.com/ijnek/soccer_visualization.git and 

But that's fixed in main: #31739
Ahh this is testing those because this one is different from main, in the removal way. It needs to be rebased.

@cottsay
Copy link
Member

cottsay commented Jan 12, 2022

Probably related to #31439 (comment)

Rebase or merge from master should help.

@nuclearsandwich
Copy link
Member Author

Rebase or merge from master should help.

Thanks and welcome back but see you next week!

Since all supported Debian and Ubuntu distributions now provide this key
the distribution version/codename can be elided.
It was pointed out in review that while all current Debian and Ubuntu
platforms provide this package with the gtk3 backend, changing it while
these platforms are still active is an unecessary disruption so rather
than fully eliding version we'll use the gtk3 backended package for
distributions except those that are currently supported or recently
unsupported.
@jacobperron jacobperron merged commit 4591f64 into master Jan 20, 2022
@clalancette clalancette deleted the nuclearsandwich/wxwidgets branch March 21, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants