-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wxwidgets key. #31699
Update wxwidgets key. #31699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a weird rename but it appears to be on all platforms.
Debian: https://packages.debian.org/buster/libwxgtk3.0-gtk3-dev
Ubuntu: https://packages.ubuntu.com/bionic/libwxgtk3.0-gtk3-dev
But digging in a little deeper the two ubuntu packages on bionic don't provide the same files:
https://packages.ubuntu.com/bionic/amd64/libwxgtk3.0-dev/filelist
vs https://packages.ubuntu.com/bionic/amd64/libwxgtk3.0-gtk3-dev/filelist which clearly is necessary to avoid installation collisions. But what is the difference between /usr/lib/x86_64-linux-gnu/libwx_gtk2u_adv-3.0.so and /usr/lib/x86_64-linux-gnu/libwx_gtk3u_adv-3.0.so
I suggest that we not fully collapse these rules but keep the new rule as a wildcard and make a special rule for existing platforms (bionic, stretch, and buster) with the existing keys. It's a little less cleanup, but will be much less likely to break someone.
We had an odd CI failure on this one failing in the setup stage: https://github.com/ros/rosdistro/runs/4784291694?check_suite_focus=true
Retriggering it now fails for two parallel issues
And soccer_visualization is out of date
But that's fixed in main: #31739 |
Probably related to #31439 (comment) Rebase or merge from master should help. |
Thanks and welcome back but see you next week! |
Since all supported Debian and Ubuntu distributions now provide this key the distribution version/codename can be elided.
It was pointed out in review that while all current Debian and Ubuntu platforms provide this package with the gtk3 backend, changing it while these platforms are still active is an unecessary disruption so rather than fully eliding version we'll use the gtk3 backended package for distributions except those that are currently supported or recently unsupported.
0a4208f
to
27d47c3
Compare
Since all supported Debian and Ubuntu distributions now provide this key
the distribution version/codename can be elided.