Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Humble Branch from Rolling #32784

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Create Humble Branch from Rolling #32784

merged 3 commits into from
Apr 20, 2022

Conversation

audrow
Copy link
Contributor

@audrow audrow commented Apr 15, 2022

The first steps in creating a new branch for Humble Hawksbill from Rolling.

Migration command:

python migration-tools/migrate-rosdistro.py \
  --source rolling \
  --source-ref f499b3cf55d5a35e0a89f158f089cd5305b12016 \
  --dest humble \
  --release-org ros2-gbp > migration.out 2> migration.err

31 failed to bloom successfully. This is most frequently caused by missing rosdep dependencies.

@github-actions github-actions bot added the humble Issue/PR is for the ROS 2 Humble distribution label Apr 15, 2022
@audrow audrow requested a review from nuclearsandwich April 15, 2022 17:23
@audrow audrow self-assigned this Apr 15, 2022
@audrow audrow changed the title Humble Create Humble Branch from Rolling Apr 15, 2022
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved not to merge, but to use as the basis for the humble migration.

The errors in tests are due to conflicts with requirements from the migration tool and that of the other tests which are run. These conflicts vanish once the distribution has any content.

paudrow added 2 commits April 19, 2022 16:25
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
@nuclearsandwich
Copy link
Member

This is most frequently caused by missing rosdep dependencies.

For this run the primary cause is actually that the release was still missing in Rolling after the Jammy migratio (#32036). rosdep resolution failure for any platform, including RHEL 8 and Debian Bullseye can block the migration script which has no way to know which platforms are "critical" and which aren't. So we can restore a good few of these with a normal manual bloom-release after the migration.

@nuclearsandwich
Copy link
Member

nuclearsandwich commented Apr 20, 2022

  • Packages which need work

    • control_box_rst
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '4', '--unsafe', 'humble']' returned non-zero exit status 1.
    • control_msgs
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '4', '--unsafe', 'humble']' returned non-zero exit status 1.
    • cyclonedds
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • fastcdr
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • fastrtps
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '4', '--unsafe', 'humble']' returned non-zero exit status 1.
    • fmi_adapter
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • fmilibrary_vendor
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • ignition_cmake2_vendor
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • ignition_math6_vendor
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • locator_ros_bridge
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • mrpt2
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • ntpd_driver
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • ompl
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
    • rmw_connextdds
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • ros_workspace
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '5', '--unsafe', 'humble']' returned non-zero exit status 1.
    • rosbag2
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • rosbag2_storage_mcap
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • usb_cam
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '2', '--unsafe', 'humble']' returned non-zero exit status 1.
    • v4l2_camera
      • Command '['git', 'bloom-release', '--non-interactive', '--release-increment', '3', '--unsafe', 'humble']' returned non-zero exit status 1.
  • Packages skipped do to lack of current Rolling release

    • aws-robomaker-small-warehouse-world
      • aws-robomaker-small-warehouse-world is not released in the source distribution (release version is missing or blank).
    • gazebo_ros_pkgs
      • gazebo_ros_pkgs is not released in the source distribution (release version is missing or blank).
    • ign_rviz
      • ign_rviz is not released in the source distribution (release version is missing or blank).
    • moveit
      • moveit is not released in the source distribution (release version is missing or blank).
    • rmw_gurumdds
      • rmw_gurumdds is not released in the source distribution (release version is missing or blank).
    • ros1_bridge
      • ros1_bridge is not released in the source distribution (release version is missing or blank).
    • ros_ign
      • ros_ign is not released in the source distribution (release version is missing or blank).
    • rosbag2_bag_v2
      • rosbag2_bag_v2 is not released in the source distribution (release version is missing or blank).
    • rosidl_typesupport_gurumdds
      • rosidl_typesupport_gurumdds is not released in the source distribution (release version is missing or blank).
    • sdformat_urdf
      • sdformat_urdf is not released in the source distribution (release version is missing or blank).
    • warehouse_ros_mongo
      • warehouse_ros_mongo is not released in the source distribution (release version is missing or blank).
    • webots_ros2
      • webots_ros2 is not released in the source distribution (release version is missing or blank)

@audrow audrow marked this pull request as ready for review April 20, 2022 16:34
Copy link
Member

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were similar migration failures as there were with the previous migration on Rolling and some additional (and expected failures) due to patches not migrating fully when the distro name changes and with some changes to templates brought with bloom 0.11.0 used in this migration.

Once this has merged we can begin addressing some of the failures with the regular bloom workflow which needs a human operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
humble Issue/PR is for the ROS 2 Humble distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants