Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foxy] [service] Don't use a weak_ptr to avoid leaking (backport #1668) #1669

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2021

This is an automatic backport of pull request #1668 done by Mergify.
Cherry-pick of d488535 has failed:

On branch mergify/bp/foxy/pr-1668
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit d488535f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rclcpp/include/rclcpp/service.hpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added the conflicts label May 13, 2021
@ivanpauno ivanpauno self-assigned this May 13, 2021
@ivanpauno ivanpauno changed the title [service] Don't use a weak_ptr to avoid leaking (backport #1668) [foxy] [service] Don't use a weak_ptr to avoid leaking (backport #1668) May 13, 2021
@jacobperron
Copy link
Member

@ivanpauno Friendly ping. Looks like this needs some attention.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
(cherry picked from commit d488535)

# Conflicts:
#	rclcpp/include/rclcpp/service.hpp
@ivanpauno
Copy link
Member

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@ivanpauno
Copy link
Member

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@ivanpauno ivanpauno merged commit d7804e1 into foxy Oct 25, 2021
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/foxy/pr-1668 branch October 25, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants