Use rcl_clock_t jump callbacks #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 28, 2018
rclcpp/src/rclcpp/clock.cpp
Outdated
| rclcpp::JumpHandler * handler = static_cast<rclcpp::JumpHandler *>(user_data); | ||
| if (before_jump && handler->pre_callback) { | ||
| handler->pre_callback(); | ||
| } else if (handler->post_callback) { |
There was a problem hiding this comment.
The conditions in the if and else if look weird. If before_jump is true but the handler only has a post callback it is being called here?
There was a problem hiding this comment.
Added test and fixed in af09c59
Relieves rclcpp::TimeSource responsibility of calling jump callbacks.
sloretz
force-pushed
the
rclcpp_time_jump_callbacks
branch
from
9b55985
to
af09c59
Compare
dirk-thomas
approved these changes
Aug 28, 2018
|
CI testing just rclcpp since I don't expect these changes to impact anything downstream.
|
I made a mistake here. tf2_ros uses time jump callbacks and is now broken. Will fix shortly |
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Aug 5, 2022
* Implement streaming compression/decompression Distro A, OPSEC #4584 Signed-off-by: P. J. Reed <preed@swri.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relieves rclcpp::TimeSource responsibility of calling jump callbacks.
(Changed branch name to disconnect PRs)
Requires ros2/rcl#284