Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make g_rcutils_log_severity_names public and immutable. #180

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 13, 2019

Precisely what the title says. Fully exposing it and making it immutable for downstream packages to use. Needed by ros2/rcl#496.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@hidmic hidmic merged commit e70143a into master Sep 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the hidmic/bring-back-deprecated-cli branch September 13, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants