Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version stability section of quality declaration for 1.0. #256

Merged
merged 4 commits into from
Jun 4, 2020

Conversation

nuclearsandwich
Copy link
Member

1.0 for this package was bumped in 5977357 so this updates the quality declaration.

It looks to me like this might make the package level 2 or level 3. I'd appreciate a comment on that front from someone whose got more familiarity with what's part of each quality level.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich self-assigned this Jun 1, 2020
@ahcorde
Copy link
Contributor

ahcorde commented Jun 2, 2020

coverage is not yet ready. It's QD 3.

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich
Copy link
Member Author

Bumped to QL3.

Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md needs to be updated too

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich
Copy link
Member Author

README.md needs to be updated too

I think it's really unfortunate we duplicate this info. What do we think of just linking to the quality declaration? Yeah it's "one more click" but it's one less way to be wrong.

@Blast545
Copy link
Contributor

Blast545 commented Jun 3, 2020

We have discussed we should have some sort of badges similar to the ones shown with CI results, but for the time being is yet too be implemented.

In fact I just realized with this PR you should update too the table at the end of the QD with a check for version stability.

@nuclearsandwich
Copy link
Member Author

In fact I just realized with this PR you should update too the table at the end of the QD with a check for version stability.

🤦

Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
@nuclearsandwich nuclearsandwich requested a review from ahcorde June 3, 2020 19:51
@nuclearsandwich nuclearsandwich merged commit 9558a3f into master Jun 4, 2020
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/quality-declaration branch June 4, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants