Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique network flows #294

Merged
merged 21 commits into from
Apr 5, 2021
Merged

Unique network flows #294

merged 21 commits into from
Apr 5, 2021

Conversation

anamud
Copy link
Contributor

@anamud anamud commented Dec 21, 2020

This PR implements unique network flows for publishers and subscribers in communicating nodes.

Associated pull-requests:

Initial contributions stem from Ericsson and eProsima.

Signed-off-by: Ananya Muddukrishna ananya.x.muddukrishna@ericsson.com

anamud and others added 2 commits November 18, 2020 07:50
Update to latest upstream
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
@wjwwood
Copy link
Member

wjwwood commented Mar 31, 2021

@Mergifyio rebase

@mergify
Copy link

mergify bot commented Mar 31, 2021

Command rebase: failure

Pull request can't be updated with latest base branch changes
Mergify needs the author permission to update the base branch of the pull request.
Ericsson needs to authorize modification on its head branch.
err-code: 51E08

@wjwwood
Copy link
Member

wjwwood commented Mar 31, 2021

@anamud can you rebase this pull request onto master? Probably worth doing that now for all the pull requests if you can. Just so they're up-to-date.

Ananya Muddukrishna added 9 commits April 1, 2021 11:27
- Option enabled for publishers and subscriptions
- TODO: Discuss error handling if option is not supported

Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
More options are required to capture application intent.

Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
@anamud
Copy link
Contributor Author

anamud commented Apr 1, 2021

@anamud can you rebase this pull request onto master? Probably worth doing that now for all the pull requests if you can. Just so they're up-to-date.

Done! Tested OK.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but generally looks pretty good.

rmw/include/rmw/network_flow_endpoint.h Outdated Show resolved Hide resolved
rmw/include/rmw/network_flow_endpoint.h Outdated Show resolved Hide resolved
rmw/include/rmw/network_flow_endpoint_array.h Outdated Show resolved Hide resolved
rmw/include/rmw/network_flow_endpoint_array.h Outdated Show resolved Hide resolved
rmw/src/network_flow_endpoint.c Show resolved Hide resolved
rmw/src/network_flow_endpoint.c Outdated Show resolved Hide resolved
rmw/src/network_flow_endpoint.c Show resolved Hide resolved
rmw/src/network_flow_endpoint.c Outdated Show resolved Hide resolved
rmw/src/network_flow_endpoint.c Outdated Show resolved Hide resolved
Ananya Muddukrishna added 8 commits April 3, 2021 12:55
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Signed-off-by: Ananya Muddukrishna <ananya.x.muddukrishna@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants