This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Implement the rmw_get_publishers/subscriptions_info_by_topic() methods #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaofei <miaofei@amazon.com>
mm318
force-pushed
the
miaofei/rmw_get_topic_info
branch
from
11feb3d to
f4a73e7
Compare
|
I will be adding tests, but this pull request is ready to start reviewing. |
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
Feb 21, 2020
There was a problem hiding this comment.
I skimmed this, and it looks ok to me.
However I'd like @ivanpauno or @hidmic to have a look at it too. They're out of the office for a while though, so it may be mid next week before we get back to it. Sorry for the delay.
Signed-off-by: Miaofei <miaofei@amazon.com>
|
Initial CI run for this change: ros2/ros2cli#385 (comment) |
Signed-off-by: Miaofei <miaofei@amazon.com>
ivanpauno
approved these changes
Feb 26, 2020
rmw_connext_shared_cpp/include/rmw_connext_shared_cpp/topic_cache.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Miaofei <miaofei@amazon.com>
wjwwood
approved these changes
Feb 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #380.