Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rmw_context_impl_t definition #65

Merged
merged 2 commits into from
Sep 14, 2021
Merged

Update rmw_context_impl_t definition #65

merged 2 commits into from
Sep 14, 2021

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 8, 2021

Connected to ros2/rmw#313.

@hidmic
Update rmw_context_impl_t definition
b6fb7c1 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from asorbini September 8, 2021 18:24
clalancette
clalancette reviewed Sep 13, 2021
View reviewed changes
rmw_connextdds_common/include/rmw_connextdds/context.hpp
@@ -58,7 +58,7 @@ enum class RMW_Connext_RequestReplyMapping
Extended
};

struct rmw_context_impl_t
struct rmw_context_impl_s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as ros2/rmw_fastrtps#558 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See c447213.

@hidmic
Comment struct rmw_context_impl_s definition
c447213 
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic
Copy link
Contributor Author

hidmic commented Sep 14, 2021

Full CI (from ros2/rmw#313):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@hidmic hidmic merged commit 380ff6f into master Sep 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-rmw-docs branch September 14, 2021 19:47
@asorbini
Copy link
Collaborator

@hidmic thank you for the update and apologies for missing out on this PR. I just tried cloning the RMW and build it with the an updated binary installation of Rolling, and I'm experiencing some build failures.

It looks like my local copy of the rmw package still defines rmw_context_impl_t. Do you know if ros2/rmw#313 has been included in a new release and, if it hasn't, when will it be released?

@asorbini
Copy link
Collaborator

I see that the changes in rmw should have been released already (since ros/rosdistro#30796 was merged), but even after an update, the package is still at version 4.0.0-1focal.20210810.175338.

@clalancette
Copy link
Contributor

I see that the changes in rmw should have been released already (since ros/rosdistro#30796 was merged), but even after an update, the package is still at version 4.0.0-1focal.20210810.175338.

Yeah, that's because we've had some core packages fail to build on the buildfarm. When that happens, nothing gets pushed out. We're looking at fixing that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@asorbini asorbini Awaiting requested review from asorbini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hidmic @asorbini @clalancette