Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a utility function to limit rmw_time_t to 32-bit values #37

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Create a utility function to limit rmw_time_t to 32-bit values #37

merged 4 commits into from
Nov 10, 2020

Commits on Nov 4, 2020

  1. Create a utility function to limit rmw_time_t to 32-bit values 

    The RMW layer maintains the rmw_time_t's seconds and nanoseconds
values as 64-bit unsigned integers. However, the DDS standard
specifies the Time_t and Duration_t types with "long sec" and
"unsigned long nanosec", and the IDL to C++11 mapping states that
the C++ types for long and unsigned long are mapped to int32_t and
uint32_t, respectively. This difference can result in the seconds
(and/or nanoseconds) value being truncated and incorrect, causing
other downstream failures. This function can be used in different
RMW adaptation layers that interface to the DDS providers when
converting from rmw_time_to to the DDS Duration_t (or Time_t),
such as rmw_time_to_fast_rtps.

Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    64fb18b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Change name of function based on code review feedback 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    5d7fa90 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. One more name change for the function 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    72c8a9d View commit details
    Browse the repository at this point in the history

  2. Fix uncrustify issues 

    Signed-off-by: Michael Jeronimo <michael.jeronimo@openrobotics.org>
    @mjeronimo
    mjeronimo committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    79c5aad View commit details
    Browse the repository at this point in the history