Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile warning with -Wsign-compare #288

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Fix compile warning with -Wsign-compare #288

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d115e9b
Use correct type for bounds check on QoS queue size
cottsay Jun 7, 2019
92e6d7e
Fix compile warning with -Wsign-compare
cottsay Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rmw_fastrtps_shared_cpp/src/qos.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ bool fill_entity_qos_from_profile(
eprosima::fastrtps::KEEP_LAST_HISTORY_QOS == history_qos.kind &&
static_cast<size_t>(history_qos.depth) < qos_policies.depth)
{
if (qos_policies.depth > (std::numeric_limits<int32_t>::max)()) {
if (qos_policies.depth > (std::numeric_limits<size_t>::max)()) {
RMW_SET_ERROR_MSG(
"failed to set history depth since the requested queue size exceeds the DDS type");
return false;
Expand Down