Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashing backport] Use rcpputils::find_and_replace instead of std::regex_replace #307

Merged
merged 1 commit into from
Jul 29, 2019
Merged

[dashing backport] Use rcpputils::find_and_replace instead of std::regex_replace #307

merged 1 commit into from
Jul 29, 2019

Conversation

jacobperron
Copy link
Member

Backport #291

Depends on ros2/rcpputils#17

@jacobperron
Use rcpputils::find_and_replace instead of std::regex_replace (#291)
5f92397 
The rcpputils implementation is more performant.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Member Author

jacobperron commented Jul 26, 2019 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 75904af into dashing Jul 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/backport_291 branch July 29, 2019 16:42
@jacobperron jacobperron changed the title Use rcpputils::find_and_replace instead of std::regex_replace [dashing backport] Use rcpputils::find_and_replace instead of std::regex_replace Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloretz sloretz sloretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobperron @sloretz